Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

simple-application.md: consistent use of type=submit #2657

Merged
merged 1 commit into from
Feb 14, 2021
Merged

simple-application.md: consistent use of type=submit #2657

merged 1 commit into from
Feb 14, 2021

Conversation

danbst
Copy link
Contributor

@danbst danbst commented Feb 13, 2021

Description

When following tutorial and typing everything in, I was confused that Save button didn't work. Turned out that tutorial switches type from "button" to "submit", which I haven't spotted. Perhaps it should had been "submit" from start?

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation change

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • I have updated docs/changelog.md

@danbst
simple-application.md: consistent use of type=submit
69e41c1 
When following tutorial and typing everything in, I was confused that Save button didn't work. Turned out that tutorial switches type from "button" to "submit", which I haven't spotted. Perhaps it should had been "submit" from start?
@danbst danbst requested a review from dead-claudia as a code owner February 13, 2021 15:53
@danbst
Copy link
Contributor Author

danbst commented Feb 13, 2021

Looks like this is followup to #1758

@dead-claudia dead-claudia merged commit 773e570 into MithrilJS:next Feb 14, 2021
@danbst danbst deleted the patch-1 branch February 19, 2021 18:53
@JAForbes JAForbes mentioned this pull request Apr 28, 2022
Merged
StephanHoyer pushed a commit that referenced this pull request May 16, 2022
@danbst @StephanHoyer
simple-application.md: consistent use of type=submit (#2657)
2818650 
When following tutorial and typing everything in, I was confused that Save button didn't work. Turned out that tutorial switches type from "button" to "submit", which I haven't spotted. Perhaps it should had been "submit" from start?
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dead-claudia dead-claudia dead-claudia approved these changes

Assignees
No one assigned
Labels
None yet
Projects
Triage/bugs
Status: Closed
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@danbst @dead-claudia