Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2604: correct and move text about statements in view method #2748

Merged
merged 1 commit into from
Feb 22, 2022
Merged

2604: correct and move text about statements in view method #2748

merged 1 commit into from
Feb 22, 2022

Conversation

kevinfiol
Copy link
Contributor

@kevinfiol kevinfiol commented Feb 21, 2022

Description

Addresses #2604

Motivation and Context

Implements suggestions (gitter.im message) from @dead-claudia to correct statement about deoptimizations from statements in the view method.

Issue: #2604

How Has This Been Tested?

Ran npm run lint:docs

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation change

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • I have updated docs/changelog.md

@StephanHoyer StephanHoyer reopened this Feb 22, 2022
@StephanHoyer StephanHoyer merged commit 0aed779 into MithrilJS:next Feb 22, 2022
@JAForbes JAForbes mentioned this pull request Apr 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Closed
Development

Successfully merging this pull request may close these issues.

3 participants