Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

m.censor: work around a bunder bug #2752

Merged
merged 1 commit into from
Mar 1, 2022
Merged

Conversation

kfule
Copy link
Contributor

@kfule kfule commented Feb 23, 2022

The internal bundler sometimes mangles the words in RegExp literals incorrectly.

Please see below.

var magic = /^(?:key7|oninit|oncreate|onbeforeupdate|onupdate|onbeforeremove|onremove1)$/

This fix uses RegExp() instead of the RegExp literal.

Description

Motivation and Context

How Has This Been Tested?

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation change

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • I have updated docs/changelog.md

@kfule kfule requested a review from StephanHoyer as a code owner February 23, 2022 03:10
Copy link
Member

@StephanHoyer StephanHoyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we should really merge @dead-claudia s PR and that replaces the bundler

@StephanHoyer
Copy link
Member

Just saw @dead-claudia closed it :(

@StephanHoyer StephanHoyer merged commit c8df665 into MithrilJS:next Mar 1, 2022
@kfule kfule deleted the fix-censor branch March 5, 2022 02:20
@JAForbes JAForbes mentioned this pull request Apr 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants