Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing prerelease branch target. #2781

Merged
merged 1 commit into from
Jun 6, 2022

Conversation

JAForbes
Copy link
Collaborator

@JAForbes JAForbes commented Jun 5, 2022

Addresses this issue JAForbes/pr-release#345 (raised by @pygy)

Description

Without specifying target:master the prerelease version calculation would be incorrect as it would never find the open release candidate PR.

Motivation and Context

JAForbes/pr-release#345

How Has This Been Tested?

Reproduced and repaired in the debugger locally.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation change
  • Operations change

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • I have updated docs/changelog.md

Without specifying target:master the prerelease version calculation would be incorrect.
@StephanHoyer StephanHoyer merged commit da1454b into next Jun 6, 2022
@StephanHoyer StephanHoyer deleted the jf/add-missing-prerelease-target branch June 6, 2022 10:57
@JAForbes JAForbes mentioned this pull request Jun 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Closed
Development

Successfully merging this pull request may close these issues.

2 participants