test-perf: Load Benckmark.js first in Node.js #3008
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Since Node21, global.navigator has been implemented, and together with browserMock, Benchmark.js incorrectly identifies the execution environment as a browser. It causes error on
npm run perf
in newer nodejs.If Benchmark.js is loaded before browserMock, the misidentification will be avoided.
Motivation and Context
I have run
npm run perf
in some environments and found that the newer nodejs versions have an error.The problem seemed to be caused by benchmark.js misidentifying the execution environment as a browser.
How Has This Been Tested?
I ran
npm run perf
on node22 and confirmed that no errors occurred.Of course, node 18 and 20 do not cause errors. Also, benchmark results should not be affected.
Types of changes
Checklist