Adapt to latest changes at Portainer & GitHub #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use wildcards for most of the binaries that are copied to avoid errors when building the latest images (kompose has been removed). Also adding helm to the list of binaries that should be added.
Use the value from the github context so the workflow can build in forks
This is to avoid warnings and running on deprecated versions of node, and avoid deprecated GHA features
|
And ... the workflows tweaks had unexpected implications... Let me fix that. I have converted this to a draft. |
This because the GitHub repository might contain uppercase letter, while Docker image names need to contain lowercase letters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This provides a few improvements to adapt to changes at dependencies of this repo:
komposehas fallen out of the Portainer image, the Dockefile uses wildcards when copying the binaries to cope with cases wherekomposeis present, and cases where it is not (as it will not be present in recent versions of the image).The workflows have been tweak so they can run within a fork and be properly tested. This has no implications on the original project.