fix: Resolve PATH environment issue in FuzzyGrep.runCommand #106
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Switched from `ProcessBuilder` to `GeneralCommandLine` to ensure proper PATH inheritance in IntelliJ plugins.
|
Hey, thanks for the PR! I'll verify that this works as expected and get back to you |
MituuZ
reviewed
Mar 3, 2025
|
Awesome! Thanks for verifying I'll include this in the next release @gymynnym do you mind if I include a shout-out for you in the release notes? |
|
Of course! It has been a good experience thanks to you. |
|
I'll close this one and merge it in #108 instead. I included some cleanup and added popup title updates to indicate which command is running Uploaded a preview version of the changes to the marketplace. Gonna run it for a day or two before the actual release |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In
FuzzyGrep.runCommand, the test environment (e.g., runIde) applies the PATH variable normally, allowing tests to succeed without issues. However, in the actual built plugin, the PATH is limited to basic values such as /usr/bin, which means commands like rg (installed via Homebrew) are not recognized.To address this, the command execution method was changed from ProcessBuilder to GeneralCommandLine so that IntelliJ properly inherits the PATH environment as described here:
https://stackoverflow.com/questions/78851077/intellij-plugin-deficient-path-environment-variable
ProcessBuildertoGeneralCommandLineto ensure proper PATH inheritance in IntelliJ plugins.