Add stats #125
Open
Add stats #125
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ThisNils
suggested changes
Jan 4, 2023
| @@ -0,0 +1,27 @@ | |||
| ## User Collection Stats (BULK) | |||
There was a problem hiding this comment.
i think i would merge this with the regular stats bulk endpoint, with category as an optional query param
|
|
||
| ``startDate``: 0 (for alltime) or set for custom time-window | ||
|
|
||
| ``endDate``: 9223372036854775807 (for alltime) or set for custom time-window |
There was a problem hiding this comment.
wouldn't leaving out the endDate mean alltime?
i think it should also be documented what format those numbers have
| | - | - | - | | ||
| | https://statsproxy-public-service-live.ol.epicgames.com/statsproxy/api/statsv2/account/:accountId | `GET` | Yes | | ||
|
|
||
| ## Parameters |
There was a problem hiding this comment.
startDate and endDate are missing here
| "startDate": 0, | ||
| "endDate": 9223372036854775807, | ||
| "owners": ["accountId"], | ||
| "stats": ["s22_social_bp_level"] |
There was a problem hiding this comment.
stats could be any stats key. you should probably put in a placeholder value and document it below
| } | ||
| ``` | ||
|
|
||
| ## Parameters |
There was a problem hiding this comment.
startDate and endDate should be documented aswell
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.