Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Tracking] Create Unity-tests equivalent to GazeFallbackWhenEyeGazeLosesTrackingTest() and GazeFallbackWhenEyeGazeIsDisabledTest() once new MRTKRig for XRI3 migration settles down #747

Closed
ms-RistoRK opened this issue May 17, 2024 · 2 comments
Assignees
Labels
Needed By: Microsoft The affiliated organization, Microsoft, depends on this issue. Needs: Unit Tests The pull request or issue needs to have unit tests created or defined. Package: Input The Project input package is impacted by this issue. Priority: High The priority of the issue is high. Type: Bug A problem with an existing feature that can be fixed with the next patched release. Type: Unit Test An issue or discussion topic related to unit tests

Comments

@ms-RistoRK
Copy link
Contributor

ms-RistoRK commented May 17, 2024

Create Unity-tests equivalent to GazeFallbackWhenEyeGazeLosesTrackingTest() and GazeFallbackWhenEyeGazeIsDisabledTest() for the new TrackedPoseDriverWithFallback functionality once the new MRTKRig for XRI3 migration settles down.

Note: Filing it as bug for easy reminder.

Related PR: #746

Branch: https://github.com/ms-RistoRK/MixedRealityToolkit-Unity/tree/XRI3Migration-tris

@ms-RistoRK ms-RistoRK added Type: Bug A problem with an existing feature that can be fixed with the next patched release. Needed By: Microsoft The affiliated organization, Microsoft, depends on this issue. Package: Input The Project input package is impacted by this issue. Type: Unit Test An issue or discussion topic related to unit tests Priority: Low The priority of the issue is low. Needs: Unit Tests The pull request or issue needs to have unit tests created or defined. labels May 17, 2024
@ms-RistoRK ms-RistoRK self-assigned this May 17, 2024
@AMollis
Copy link
Contributor

AMollis commented May 20, 2024

@ms-RistoRK this needs to be fixed before XRI3 support is shipped

@AMollis AMollis added Priority: High The priority of the issue is high. and removed Priority: Low The priority of the issue is low. labels May 20, 2024
ms-RistoRK added a commit that referenced this issue May 21, 2024
Aiming for the goal of deprecating MRTK3 controllers, in this PR:
* Added TrackedPoseDriverWithFallback that will replace
ActionBasedControllerWithFallbacks
* Adding TrackedPoseDriverWithFallback component to
Experimental-XRI3/MRTKGazeController/GazeInteractor prefab + linking
Position, Rotation, and TrackingState actions and corresponding
fallbacks. The Experimental-XRI3/MRTKGazeController/GazeInteractor now
looks like this:

![image](https://github.com/MixedRealityToolkit/MixedRealityToolkit-Unity/assets/84108471/54f249b2-1a94-46f4-928e-40f7a7541715)

* Updated unity-tests so that the old functionality of
ActionBasedControllerWithBallbacks functionality is still properly
tested.

Note: Created an [issue for tracking the development of unity-tests for
the new TrackedPoseDriverWithFallback once the new MRTKRig for XRI3
migration settles
down](#747).

Manual testing that this fallback functionality works was done with the
following steps:
1 - Made a sideload install of HL2.
2 - Run the app and granted eye-tracking permissions.
3 - Opened a scene with multiple objects that when selected (via
'select' utterance) would be highlighted with a bounding box or other
permanent visual until de-selected.
4 - With eye-gaze selected object with 'select' utterance. This
confirmed that eye-gaze input actions was providing data.
5 - Oriented HL2 toward an empty space.
6 - Closed my eyes and made 'select' utterance.
7 - Opened my eyes and confirmed nothing was selected.
8 - Oriented HL2 towards a selectable object.
9 - Closed my eyes and made 'select' utterance.
10 - Opened my eyes and confirmed that the object aligned in front of
HL2 was selected. This confirmed that when eye-gaze input actions did
not provide data then the data from the fallback (head) input actions
was used.
@ms-RistoRK
Copy link
Contributor Author

Fixed in feature/XRI3 branch, closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needed By: Microsoft The affiliated organization, Microsoft, depends on this issue. Needs: Unit Tests The pull request or issue needs to have unit tests created or defined. Package: Input The Project input package is impacted by this issue. Priority: High The priority of the issue is high. Type: Bug A problem with an existing feature that can be fixed with the next patched release. Type: Unit Test An issue or discussion topic related to unit tests
Projects
None yet
Development

No branches or pull requests

2 participants