Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[XRI3] Solver Target "Hand Ray" does not work in XRI3 feature branch #877

Closed
AMollis opened this issue Jul 25, 2024 · 4 comments · Fixed by #879
Closed

[XRI3] Solver Target "Hand Ray" does not work in XRI3 feature branch #877

AMollis opened this issue Jul 25, 2024 · 4 comments · Fixed by #879
Assignees
@AMollis
Labels
Type: Bug A problem with an existing feature that can be fixed with the next patched release. Type: Example An issue related to an example or sample.

Comments

@AMollis
Copy link
Contributor

AMollis commented Jul 25, 2024

Describe the bug

A clear and concise description of what the bug is.

To reproduce

Steps to reproduce the behavior:

  1. Build the Features/XRI3 sample project
  2. On HL2 go to SolverExamples.unity scene
  3. On the "Solver Handlers" dialog, select "Hay Ray Target" for the "Solver Target"
  4. Result: "Solver Object" does not move

Expected behavior

Expected: "Solver Object" to follow the hand ray
@AMollis AMollis added Type: Bug A problem with an existing feature that can be fixed with the next patched release. Package: Spatial Manipulation The Project spatial manipulation package is impacted by this issue. labels Jul 25, 2024
@AMollis AMollis self-assigned this Jul 25, 2024
This was referenced Jul 25, 2024
Open
Open
@AMollis AMollis changed the title [MRTK] [XRI3] Solver Target "Hand Ray" does not work in XRI3 feature branch [XRI3] Solver Target "Hand Ray" does not work in XRI3 feature branch Jul 25, 2024
@AMollis
Copy link
Contributor Author

AMollis commented Jul 25, 2024

The problem here is that the hand ray interactors aren't set on the test script

image

@AMollis
Copy link
Contributor Author

AMollis commented Jul 25, 2024

Setting the interactors on the test script fixes the issue

image

@AMollis AMollis added Type: Example An issue related to an example or sample. and removed Package: Spatial Manipulation The Project spatial manipulation package is impacted by this issue. labels Jul 25, 2024
@AMollis
Copy link
Contributor Author

AMollis commented Jul 25, 2024

This is a "sample only" issue.

@AMollis AMollis mentioned this issue Jul 25, 2024
Merged
@AMollis AMollis linked a pull request Jul 25, 2024 that will close this issue
[XRI3] Fixing broken references in sample scenes in XRI3 feature branch. #879
Merged
AMollis added a commit that referenced this issue Jul 25, 2024
@AMollis
[XRI3] Fixing broken references in sample scenes in XRI3 feature bran…
b4e332c 
…ch. (#879)

# Overview 

After updating sample scenes to the new XRI3 rig, some interactor
references broke on some test behaviours. This change fixes these
issues.

Also adjusting a game object name in the "SolverExample" scene, to
better example what the game object is.

# Fixes

-
#878
-
#877
-
#876

# Inspector/Scene Updates

### Spatial Mouse Sample Scene Changes
Updates scene to use the MRTK3/XRI3 Rig Prefab, this fixed broken
interactor references


![image](https://github.com/user-attachments/assets/d9f7f24d-ed8e-467a-9a34-b2724dc0801f)

###  Solver Examples Scene Changes
Adding hand ray interactor references on the `SolverExampleManager` test
behaviour


![image](https://github.com/user-attachments/assets/58a4b9c7-66cd-4db7-bda1-d3c52f07a753)

### Eye Tracking Visualizer Example Scene Changes
Adding gaze interactor references on the `LogStructureEyeGaze` test
behaviour.


![image](https://github.com/user-attachments/assets/f0154bd6-6530-4dc3-b7d5-bed9d4fbeaf2)
@AMollis
Copy link
Contributor Author

AMollis commented Jul 25, 2024

Fixed

@AMollis AMollis closed this as completed Jul 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@AMollis AMollis

Labels
Type: Bug A problem with an existing feature that can be fixed with the next patched release. Type: Example An issue related to an example or sample.
Projects
None yet
Milestone
No milestone
1 participant
@AMollis