add bearer auth capabilities to http transport; (winstonjs#1662)

* add bearer auth capabilities to http transport; * replace headers clone via spread operator with Object.assign for node 6 compatibility;
Mizumaki · Aug 15, 2019 · 8b27583 · 8b27583
1 parent 7f5e9b2
commit 8b27583
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 4 deletions.
diff --git a/lib/winston/transports/http.js b/lib/winston/transports/http.js
@@ -177,13 +177,17 @@ module.exports = class Http extends TransportStream {
     delete options.path;
 
     // Prepare options for outgoing HTTP request
+    const headers = Object.assign({}, this.headers);
+    if (auth && auth.bearer) {
+      headers['Authorization'] = `Bearer ${auth.bearer}`;
+    }
     const req = (this.ssl ? https : http).request({
       method: 'POST',
       host: this.host,
       port: this.port,
       path: `/${path.replace(/^\//, '')}`,
-      headers: this.headers,
-      auth: auth ? (`${auth.username}:${auth.password}`) : '',
+      headers: headers,
+      auth: (auth && auth.username && auth.password) ? (`${auth.username}:${auth.password}`) : '',
       agent: this.agent
     });
 

diff --git a/lib/winston/transports/index.d.ts b/lib/winston/transports/index.d.ts
@@ -55,7 +55,7 @@ declare namespace winston {
     ssl?: any;
     host?: string;
     port?: number;
-    auth?: { username: string; password: string; };
+    auth?: { username?: string | undefined, password?: string | undefined, bearer?: string | undefined };
     path?: string;
     agent?: Agent;
     headers?: object;
@@ -66,7 +66,7 @@ declare namespace winston {
     ssl: boolean;
     host: string;
     port: number;
-    auth?: { username: string, password: string };
+    auth?: { username?: string | undefined, password?: string | undefined, bearer?: string | undefined };
     path: string;
     agent?: Agent | null;