-
-
Notifications
You must be signed in to change notification settings - Fork 121
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change tag type (int -> uint) and add the tag MG_OVERLAP (for ParMmg) #280
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #280 +/- ##
===========================================
- Coverage 50.46% 50.44% -0.02%
===========================================
Files 176 177 +1
Lines 47224 47236 +12
Branches 10267 10276 +9
===========================================
- Hits 23832 23830 -2
- Misses 15657 15674 +17
+ Partials 7735 7732 -3 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks,
From my side I still have few warnings about tag types mismatch (fro now, the build is tested without Elas and VTK):
src/mmg3d/swap_3d.c:353
src/mmg3d/intmet_3d.c:99
Best
.vscode/c_cpp_properties.json
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think that this file should not be added to the commit ( no link with the PR + private paths inside it).
src/common/API_functions.c
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This function is not covered by the tests: it is not directly linked to your PR but I will propose a unit test as it is the occasion to improve the code coverage of this part of the software.
@@ -2002,6 +2002,7 @@ int MMG5_bdrySet(MMG5_pMesh mesh) { | |||
for (k=1; k<=mesh->ne; k++) { | |||
pt = &mesh->tetra[k]; | |||
if ( !MG_EOK(pt) ) continue; | |||
if (pt->tag & MG_OVERLAP) continue; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For all this kind of tests, for now I am not able to say if they are valid, but:
- It should not impact Mmg;
- I trust you that it is what we want to do in ParMmg ;-).
This reverts commit e496a19.
int
, and in now unsigned integeruint
. This was needed to be able to add extra tags if wanted.common/mmgcommon_private.h
: add the tagMG_OVERLAP
useful to create and delete the overlap in ParMmg.mmg3d/hash_3d.c
, functionMMG5_bdrySet
: skip some part of the analysis if the tetra is taggedMG_OVERLAP
- useful when an overlap is created in ParMmg to ignore overlapping tetra.