Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change tag type (int -> uint) and add the tag MG_OVERLAP (for ParMmg) #280

Merged
merged 14 commits into from
Sep 10, 2024

Conversation

laetitia-m
Copy link
Contributor

  1. The type of tag was signed integer int, and in now unsigned integer uint. This was needed to be able to add extra tags if wanted.
  2. In the file common/mmgcommon_private.h: add the tag MG_OVERLAP useful to create and delete the overlap in ParMmg.
  3. In the file mmg3d/hash_3d.c, function MMG5_bdrySet: skip some part of the analysis if the tetra is tagged MG_OVERLAP - useful when an overlap is created in ParMmg to ignore overlapping tetra.

Copy link

codecov bot commented Aug 30, 2024

Codecov Report

Attention: Patch coverage is 57.89474% with 16 lines in your changes missing coverage. Please review.

Project coverage is 50.44%. Comparing base (2263f92) to head (176f3b2).
Report is 17 commits behind head on develop.

Files with missing lines Patch % Lines
cmake/testing/code/mmg_get_tagname.c 0.00% 8 Missing ⚠️
src/mmg3d/hash_3d.c 50.00% 5 Missing ⚠️
src/common/API_functions.c 0.00% 3 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #280      +/-   ##
===========================================
- Coverage    50.46%   50.44%   -0.02%     
===========================================
  Files          176      177       +1     
  Lines        47224    47236      +12     
  Branches     10267    10276       +9     
===========================================
- Hits         23832    23830       -2     
- Misses       15657    15674      +17     
+ Partials      7735     7732       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@Algiane Algiane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks,

From my side I still have few warnings about tag types mismatch (fro now, the build is tested without Elas and VTK):

src/mmg3d/swap_3d.c:353
src/mmg3d/intmet_3d.c:99

Best

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that this file should not be added to the commit ( no link with the PR + private paths inside it).

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This function is not covered by the tests: it is not directly linked to your PR but I will propose a unit test as it is the occasion to improve the code coverage of this part of the software.

@@ -2002,6 +2002,7 @@ int MMG5_bdrySet(MMG5_pMesh mesh) {
for (k=1; k<=mesh->ne; k++) {
pt = &mesh->tetra[k];
if ( !MG_EOK(pt) ) continue;
if (pt->tag & MG_OVERLAP) continue;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For all this kind of tests, for now I am not able to say if they are valid, but:

  • It should not impact Mmg;
  • I trust you that it is what we want to do in ParMmg ;-).

@Algiane Algiane added the part: mmg3d mmg3d specific label Sep 10, 2024
@Algiane Algiane merged commit 88d9d1e into MmgTools:develop Sep 10, 2024
26 checks passed
@laetitia-m laetitia-m deleted the feature/overlap branch September 10, 2024 19:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
part: mmg3d mmg3d specific
Development

Successfully merging this pull request may close these issues.

2 participants