Switch to (stateless) functional components

[MoOx]

...instead of classes.

[MoOx]

Not a good idea yet since hot loading is kind of broken with stateless component

[MoOx]

Blocked by gaearon/babel-plugin-react-transform#57

[thangngoc89]

gaearon/babel-plugin-react-transform#85

[MoOx]

The solution is pretty filthy and not reliable imo. Not even sure this will be merged.

This comment intrigued mehttps://github.com/gaearon/babel-plugin-react-transform/pull/85#issuecomment-185048429

This makes me start thinking that HMR is not optimal.
See this thread https://twitter.com/thejameskyle/status/699844680628834304

I will look at http://chromakode.github.io/isolated-core/.

[thangngoc89]

Interesting.
Keep this here just for the record https://github.com/thejameskyle/isolated-core-demo

[MoOx]

FYI gaearon/babel-plugin-react-transform#57 (comment)

[thangngoc89]

Awesome. Let's move everything to redux store.

[MoOx]

Still unsure that we need redux. Most things don't even changes (collections, layouts etc). Only pages data, and redux still not really relevant since we don't do complexe changes, but just add/replace in an object...

[thangngoc89]

Sorry. I didn't review that PR carefully. So @-gaearon is re-rendering the whole app on each hot reload right ?

[MoOx]

Yeah. But I think if we try this, we should consider http://chromakode.github.io/isolated-core/

[thangngoc89]

Isolated core mounts app to an iframe while ReactDOM mounts app to DOM. Not sure what's the best. Anyway, will give a try tmr.

[MoOx]

Meanwhile, nice light example Winwardo/solid-octo-disco@e2f22b2

[thangngoc89]

He killed his project again https://medium.com/@dan_abramov/hot-reloading-in-react-1140438583bf#.77dfvm6qh

[gaearon]

React Hot Loader 3 supports functional components without destroying the state.
It supersedes both React Hot Loader and React Transform, and is built on lessons learned from both.
Check it out: gaearon/react-hot-boilerplate#61

[thangngoc89]

@gaearon 👍 👍 best news ever

[MoOx]

webpack-2 branch now use react-hot-loader@3, so we are now able to use stateless component everywhere when possible!

[MoOx]

webpack 2 and react-hot-loader v3 are on master, so contributions are welcome:

• remove this rule

  phenomic/package.json

  Lines 233 to 236 in eb31532

  	"react/prefer-stateless-function": 0
  	}
  	},
  	"eslintConfigRuleReact/prefer-stateless-function": "https://github.com/MoOx/phenomic/issues/46",

• remove this rule in docs & default theme template
• update components!

[MoOx]

Closing in favor of #747