Fix coverage report on CI

[thangngoc89]

It's good to have coverage report back.

Right @codecov-io ?

[codecov-io]

Current coverage is 68.28%

Merging #296 into next will increase coverage by +6.76% as of 500c9dc

@@             next    #296   diff @@
=====================================
  Files          40      42     +2
  Stmts         525     637   +112
  Branches        0       0       
  Methods                         
=====================================
+ Hit           323     435   +112
  Partial         0       0       
  Missed        202     202       

Review entire Coverage Diff as of 500c9dc

Powered by Codecov. Updated on successful CI builds.

[MoOx]

why is this weird change required?

[thangngoc89]

It's AVA who spawn those processes, not npm run. nyc 6.0.0 isn't required

Hang on a sec. nyc doesn't ignore test files

[MoOx]

It was working before right?

[thangngoc89]

@MoOx yes. It was working before. No idea why it's stop working

[thangngoc89]

Related ? istanbuljs/nyc#190

[arrowrowe]

@thangngoc89 I cannot understand what causes #190. The problem is, in short, no coverage files found only using Node 5.8.0 and NPM 3.7.3. This problem disappears after updating NPM to 3.8.1 or using Node 5.7.1 instead.

[thangngoc89]

@arrowrowe We are having the same problem here. node 4 is fine. Pushed a new commit to use latest npm

[arrowrowe]

@thangngoc89 Thanks! Trying it now.

[thangngoc89]

@MoOx upgrading npm to latest version (3.8.1) did help

https://travis-ci.org/MoOx/statinamic/builds/115487336#L654-L728

[arrowrowe]

@thangngoc89 It works for me as well. Thanks!

https://travis-ci.org/arrowrowe/romi/jobs/115487555

[MoOx]

So no need for this PR right?

[thangngoc89]

@MoOx We can wait until

• nyc fixes this bug
• or a new node release which uses npm@3.8.1

[MoOx]

latest node don't get npm@^3.0.0 ? They fix the version to 3.7.x ?

[thangngoc89]

latest node is 3.8.1 https://travis-ci.org/MoOx/statinamic/builds/115487336#L215

[MoOx]

npm*

But does latest node ship this version? It seems latest node ship 3.7.x https://github.com/nodejs/node/tree/master/deps/npm (or https://github.com/nodejs/node/tree/v5.x/deps/npm )

[MoOx]

Oh my bad. I just looked at the nyc mentionned issue. So not sure what to do.

[MoOx]

We get your patch for now. Can you add a comment in it ?

[thangngoc89]

Added comment

[MoOx]

👍