Skip to content
This repository has been archived by the owner on Dec 19, 2024. It is now read-only.

Added pseudoelements PostCSS Plugin #83

Merged
merged 1 commit into from
Apr 2, 2015
Merged

Added pseudoelements PostCSS Plugin #83

merged 1 commit into from
Apr 2, 2015

Conversation

magsout
Copy link
Contributor

@magsout magsout commented Mar 30, 2015

#81

@MoOx
Copy link
Owner

MoOx commented Mar 31, 2015

This looks perfect (except the broken build, but it's related to Nyalab/caniuse-api#27).
I just would like one more thing: disable this when IE 8 in not in the browser scope.
Caniuse have some data on this http://caniuse.com/#search=before

Maybe we can add this in the caniuseFeaturesMap in order to do that? Not sure how caniuse-api handle partial support (poke @Nyalab)

@magsout
Copy link
Contributor Author

magsout commented Mar 31, 2015

Maybe we can add this in the caniuseFeaturesMap in order to do that? Not sure how caniuse-api handle partial support (poke @Nyalab)

Or maybe we should detect if ie8 is passed in option.browser, if no, we pass option to false ?

@MoOx
Copy link
Owner

MoOx commented Mar 31, 2015

@magsout yeah. Maybe we should enhance this map in order to accept callback for specific features.

@magsout
Copy link
Contributor Author

magsout commented Apr 1, 2015

caniuse.isSupported('css-content', 'ie 8') => false

@MoOx
Copy link
Owner

MoOx commented Apr 1, 2015

So, you know what to do then ?

@magsout
Copy link
Contributor Author

magsout commented Apr 1, 2015

hug

@MoOx
Copy link
Owner

MoOx commented Apr 1, 2015

Can you do 2 things:

And also update the date to tomorrow. I don't want people think it's a joke :D

@magsout
Copy link
Contributor Author

magsout commented Apr 1, 2015

Done.

@MoOx
Copy link
Owner

MoOx commented Apr 2, 2015

Last thing, if you can change the version in CHANGELOG to 1.2.0 (it's a feature not a patch) + bump in package.json, I will be perfect so I can just do

$ git pull
$ npmpublish

Ref: https://github.com/MoOx/setup/blob/master/functions/npmpublish ;)

@MoOx
Copy link
Owner

MoOx commented Apr 2, 2015

And add "Close #81" in commit description ;)

@magsout
Copy link
Contributor Author

magsout commented Apr 2, 2015

Done ;)

@MoOx
Copy link
Owner

MoOx commented Apr 2, 2015

Build is broken for example expected output not being updated and some sourcemap fix. I will handle that.

@magsout
Copy link
Contributor Author

magsout commented Apr 2, 2015

after that I added?

@MoOx
Copy link
Owner

MoOx commented Apr 2, 2015

No before :)
Well for the example.css you didn't update the expected output :p

MoOx added a commit that referenced this pull request Apr 2, 2015
Added pseudoelements PostCSS Plugin
@MoOx MoOx merged commit c6db9de into master Apr 2, 2015
@MoOx
Copy link
Owner

MoOx commented Apr 2, 2015

I will fix the build and publish. Thanks @magsout

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants