feat(): Fix Parse error on PX #76
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Semigradsky
reviewed
Nov 25, 2021
| @@ -36,6 +36,7 @@ | |||
| ([0-9]+("."[0-9]*)?|"."[0-9]+)vmin\b return 'VMINS'; | |||
| ([0-9]+("."[0-9]*)?|"."[0-9]+)vmax\b return 'VMAXS'; | |||
| ([0-9]+("."[0-9]*)?|"."[0-9]+)\% return 'PERCENTAGE'; | |||
| ([0-9]+("."[0-9]*)?|"."[0-9]+)PX\b return 'PX'; | |||
There was a problem hiding this comment.
We already have px as LENGTH above on line 13.
And looks like this fix will not work 10pX and 10Px. It is better to make lower case before sending to parser.
There was a problem hiding this comment.
We have enabled the plugin to convert PX to REM, and 50px to 1rem.
div{
width: 50px; // 1rem
width: calc(100% - 10PX); // calc(100% - 10PX)
height: calc(10px - 10PX); // calc(0.2rem -10PX)
}This CSS can be converted multiple times and needs to be uppercase at all times，and the browser supports PX，Px
This issue also appeared in postcss-calc and they fixed it(7.0.4)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#75
PX unit support
postcss-pxtoremCan write PX without converting to REM, and browsers also support PX units