Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix bug of iOS 14 beta 6 navigation bar weird behavior. #157

Merged
merged 1 commit into from
Sep 16, 2020
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,8 @@
// THE SOFTWARE.

#import "UINavigationBar+KMNavigationBarTransition.h"
#import "UINavigationBar+KMNavigationBarTransition_internal.h"
#import "KMWeakObjectContainer.h"
#import <objc/runtime.h>
#import "KMSwizzle.h"

Expand All @@ -35,6 +37,13 @@ + (void)load {
@selector(layoutSubviews),
[self class],
@selector(km_layoutSubviews));
// fix the bug of iOS14 beta 6
if (@available(iOS 14.0, *)) {
KMSwizzleMethod([self class],
NSSelectorFromString(@"_accessibility_navigationController"),
[self class],
@selector(km_accessibility_navigationController));
}
});
}
#endif
Expand All @@ -55,4 +64,24 @@ - (void)setKm_isFakeBar:(BOOL)hidden {
objc_setAssociatedObject(self, @selector(km_isFakeBar), @(hidden), OBJC_ASSOCIATION_RETAIN_NONATOMIC);
}

- (UINavigationController *) km_accessibility_navigationController {
UINavigationController * navigationController = [self km_accessibility_navigationController];
if (self.km_isFakeBar) {
// if it's fake navigation bar
// return previously bound navigationController.
return self.km_fakeController;
}
return navigationController;
}

- (UINavigationController *)km_fakeController
{
return km_objc_getAssociatedWeakObject(self, @selector(km_fakeController));
}

- (void)setKm_fakeController:(UINavigationController *)km_fakeController
{
km_objc_setAssociatedWeakObject(self, @selector(km_fakeController), km_fakeController);
}

@end
Original file line number Diff line number Diff line change
Expand Up @@ -26,5 +26,7 @@
@interface UINavigationBar (KMNavigationBarTransition_internal)

@property (nonatomic, assign) BOOL km_isFakeBar;
// store current navigation controller.
@property (nonatomic, weak) UINavigationController *km_fakeController;

@end
Original file line number Diff line number Diff line change
Expand Up @@ -128,6 +128,9 @@ - (void)km_addTransitionNavigationBarIfNeeded {
[self km_adjustScrollViewContentOffsetIfNeeded];
UINavigationBar *bar = [[UINavigationBar alloc] init];
bar.km_isFakeBar = YES;
if (@available(iOS 14.0, *)) {
bar.km_fakeController = self.navigationController;
}
bar.barStyle = self.navigationController.navigationBar.barStyle;
if (bar.translucent != self.navigationController.navigationBar.translucent) {
bar.translucent = self.navigationController.navigationBar.translucent;
Expand Down