Skip to content

Comments

[fix] 공유하기 웹뷰 브리징 제거#1105

Merged
seongwon030 merged 1 commit intodevelop-fefrom
fix/share-link-delete-bridge
Jan 25, 2026
Merged

[fix] 공유하기 웹뷰 브리징 제거#1105
seongwon030 merged 1 commit intodevelop-fefrom
fix/share-link-delete-bridge

Conversation

@seongwon030
Copy link
Member

@seongwon030 seongwon030 commented Jan 25, 2026

#️⃣연관된 이슈

ex) #이슈번호, #이슈번호

📝작업 내용

공유하기는 웹뷰에서 동작하기 때문에 브리징 작업이 필요없었습니다. 브리징 관련 코드를 제거했습니다.

중점적으로 리뷰받고 싶은 부분(선택)

리뷰어가 특별히 봐주었으면 하는 부분이 있다면 작성해주세요

ex) 메서드 XXX의 이름을 더 잘 짓고 싶은데 혹시 좋은 명칭이 있을까요?

논의하고 싶은 부분(선택)

논의하고 싶은 부분이 있다면 작성해주세요.

🫡 참고사항

Summary by CodeRabbit

릴리스 노트

  • 버그 수정
    • 공유 버튼의 공유 메커니즘을 개선했습니다. 모바일에서는 Web Share API를 우선적으로 사용하고, 이용 불가 시 클립보드로 자동 전환됩니다. 데스크톱은 클립보드 기반으로 동작합니다.

✏️ Tip: You can customize this high-level summary in your review settings.

@seongwon030 seongwon030 self-assigned this Jan 25, 2026
@vercel
Copy link

vercel bot commented Jan 25, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Review Updated (UTC)
moadong Ready Ready Preview, Comment Jan 25, 2026 7:28am

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Jan 25, 2026

Warning

.coderabbit.yaml has a parsing error

The CodeRabbit configuration file in this repository has a parsing error and default settings were used instead. Please fix the error(s) in the configuration file. You can initialize chat with CodeRabbit to get help with the configuration file.

💥 Parsing errors (1)
Validation error: Invalid regex pattern for base branch. Received: "**" at "reviews.auto_review.base_branches[0]"
⚙️ Configuration instructions
  • Please see the configuration documentation for more information.
  • You can also validate your configuration using the online YAML validator.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Walkthrough

React Native WebView 기반의 공유 메커니즘을 제거했습니다. isInAppWebView import, isRNWebView 플래그, 그리고 ReactNativeWebView를 통한 네이티브 공유 페이로드 전달 로직을 삭제했으며, 모바일에서는 Web Share API를 사용하고 폴백으로 클립보드를 활용하도록 통합했습니다.

Changes

Cohort / File(s) Summary
공유 기능 정리
frontend/src/pages/ClubDetailPage/components/ShareButton/ShareButton.tsx
React Native WebView 공유 경로 제거: isInAppWebView import, isRNWebView 조건부 분기, native_share 이벤트 추적 삭제; Web Share API 및 클립보드 폴백 로직 유지

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Possibly related PRs

Suggested labels

💻 FE

Suggested reviewers

  • suhyun113
  • oesnuj
🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed PR 제목 '[fix] 공유하기 웹뷰 브리징 제거'는 변경사항의 주요 내용을 정확하게 반영합니다.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
  • 📝 Generate docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@seongwon030 seongwon030 added 🛠Fix 기능이 의도한 대로 동작하지 않는 버그를 수정 💻 FE Frontend labels Jan 25, 2026
Copy link
Member

@oesnuj oesnuj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

불필요한 로직 제거 좋습니다!

@seongwon030 seongwon030 merged commit fcb114a into develop-fe Jan 25, 2026
3 checks passed
@seongwon030 seongwon030 deleted the fix/share-link-delete-bridge branch January 25, 2026 08:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

💻 FE Frontend 🛠Fix 기능이 의도한 대로 동작하지 않는 버그를 수정

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants