Skip to content

Comments

[fix] 필터탭 메인에서 제거 #1152

Merged
seongwon030 merged 1 commit intodevelop-fefrom
fix/remove-filtertab
Feb 8, 2026
Merged

[fix] 필터탭 메인에서 제거 #1152
seongwon030 merged 1 commit intodevelop-fefrom
fix/remove-filtertab

Conversation

@seongwon030
Copy link
Member

@seongwon030 seongwon030 commented Feb 8, 2026

#️⃣연관된 이슈

ex) #이슈번호, #이슈번호

📝작업 내용

  • 홍보게시판 완성 전에 필터탭이 메인에 있는게 이상해서 지웠습니다.

중점적으로 리뷰받고 싶은 부분(선택)

리뷰어가 특별히 봐주었으면 하는 부분이 있다면 작성해주세요

ex) 메서드 XXX의 이름을 더 잘 짓고 싶은데 혹시 좋은 명칭이 있을까요?

논의하고 싶은 부분(선택)

논의하고 싶은 부분이 있다면 작성해주세요.

🫡 참고사항

Summary by CodeRabbit

변경 사항

  • 스타일

    • 모바일 화면에서 배너의 여백이 조정되었습니다.
  • 버그 수정

    • 필터 기능이 일시적으로 비활성화되었습니다.

@seongwon030 seongwon030 self-assigned this Feb 8, 2026
@seongwon030 seongwon030 added 💻 FE Frontend 🛠Fix 기능이 의도한 대로 동작하지 않는 버그를 수정 labels Feb 8, 2026
@vercel
Copy link

vercel bot commented Feb 8, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
moadong Ready Ready Preview, Comment Feb 8, 2026 3:45am

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Feb 8, 2026

Warning

.coderabbit.yaml has a parsing error

The CodeRabbit configuration file in this repository has a parsing error and default settings were used instead. Please fix the error(s) in the configuration file. You can initialize chat with CodeRabbit to get help with the configuration file.

💥 Parsing errors (1)
Validation error: Invalid regex pattern for base branch. Received: "**" at "reviews.auto_review.base_branches[0]"
⚙️ Configuration instructions
  • Please see the configuration documentation for more information.
  • You can also validate your configuration using the online YAML validator.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Walkthrough

MainPage에서 Filter 컴포넌트를 주석 처리하여 UI를 숨기고, Banner 모바일 미디어 쿼리에서 마진 값을 0px에서 56px로 변경했습니다. 데이터 흐름이나 제어 로직에는 변화가 없습니다.

Changes

Cohort / File(s) Summary
UI 렌더링 변경
frontend/src/pages/MainPage/MainPage.tsx
Filter 컴포넌트를 주석 처리하여 필터 UI를 숨김. 임포트는 유지됨.
모바일 레이아웃 스타일링
frontend/src/pages/MainPage/components/Banner/Banner.styles.ts
모바일 미디어 쿼리 내 margin-top을 0px에서 56px로 변경.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Possibly related PRs

Suggested reviewers

  • lepitaaar
  • oesnuj
🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed 제목 '[fix] 필터탭 메인에서 제거'는 변경 사항의 주요 목적을 명확하게 요약하고 있으며, Filter 컴포넌트 제거라는 실제 변경과 정확히 일치합니다.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch fix/remove-filtertab

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Contributor

@lepitaaar lepitaaar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

임시 제거 좋습니다

Copy link
Member

@oesnuj oesnuj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

등장 전 주석처리 👍👍

@seongwon030 seongwon030 merged commit 1d3ab2b into develop-fe Feb 8, 2026
3 checks passed
@lepitaaar lepitaaar deleted the fix/remove-filtertab branch February 21, 2026 07:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

💻 FE Frontend 🛠Fix 기능이 의도한 대로 동작하지 않는 버그를 수정

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants