Skip to content

Comments

[Fix] v1.1.26 수정#1229

Merged
seongwon030 merged 4 commits intodevelop-fefrom
fix/1.1.26
Feb 22, 2026
Merged

[Fix] v1.1.26 수정#1229
seongwon030 merged 4 commits intodevelop-fefrom
fix/1.1.26

Conversation

@seongwon030
Copy link
Member

@seongwon030 seongwon030 commented Feb 22, 2026

#️⃣연관된 이슈

ex) #이슈번호, #이슈번호

📝작업 내용

지원자 상세 페이지(ApplicantDetailPage)에서 지원 상태(status) 변경 시 타입 검증 위치를 조정했습니다.

  • handleStatusChange에서 e.target.valuerawStatus로 받은 뒤 isApplicationStatus로 검증
  • updateApplicantDetail 내부의 중복 상태 검증 제거
  • memo에 대한 불필요한 타입 가드 제거
  • questionId 존재 여부 가드는 updateApplicantDetail 내부에서 유지

변경 이유

  • as ApplicationStatus 타입 단언 대신 런타임 검증을 먼저 수행해 안전성 개선
  • 상태값 검증 책임을 이벤트 입력 처리 지점(handleStatusChange)으로 이동해 함수 역할 명확화
  • updateApplicantDetail의 불필요한 방어 로직 제거로 코드 단순화

중점적으로 리뷰받고 싶은 부분(선택)

리뷰어가 특별히 봐주었으면 하는 부분이 있다면 작성해주세요

ex) 메서드 XXX의 이름을 더 잘 짓고 싶은데 혹시 좋은 명칭이 있을까요?

논의하고 싶은 부분(선택)

논의하고 싶은 부분이 있다면 작성해주세요.

🫡 참고사항

Summary by CodeRabbit

변경 사항

  • 버그 수정
    • Google Forms 외부 URL 유효성 검사 강화: 외부 애플리케이션 Google Forms URL은 이제 후행 슬래시(/)를 포함해야 합니다.

@seongwon030 seongwon030 self-assigned this Feb 22, 2026
@seongwon030 seongwon030 added 💻 FE Frontend 🛠Fix 기능이 의도한 대로 동작하지 않는 버그를 수정 labels Feb 22, 2026
@vercel
Copy link

vercel bot commented Feb 22, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
moadong Ready Ready Preview, Comment Feb 22, 2026 8:46am

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Feb 22, 2026

Warning

.coderabbit.yaml has a parsing error

The CodeRabbit configuration file in this repository has a parsing error and default settings were used instead. Please fix the error(s) in the configuration file. You can initialize chat with CodeRabbit to get help with the configuration file.

💥 Parsing errors (1)
Validation error: Invalid regex pattern for base branch. Received: "**" at "reviews.auto_review.base_branches[0]"
⚙️ Configuration instructions
  • Please see the configuration documentation for more information.
  • You can also validate your configuration using the online YAML validator.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Walkthrough

이 PR은 세 파일에서 검증 및 타입 안정성을 개선합니다. ApplicantDetailPage에서 ApplicationStatus 검증을 강화하고, ApplicantsListTab에 명시적 React 임포트를 추가하며, validateApplicationForm에서 Google Forms URL 검증을 더욱 엄격하게 만듭니다.

Changes

Cohort / File(s) Summary
상태 및 메모 처리
frontend/src/pages/AdminPage/tabs/ApplicantsTab/ApplicantDetailPage/ApplicantDetailPage.tsx
updateApplicantDetail 호출 전에 isApplicationStatus 검증을 추가하여 상태 타입 안정성을 강화하고, 사용되지 않는 useMemo 임포트를 제거했습니다.
명시적 임포트
frontend/src/pages/AdminPage/tabs/ApplicantsTab/ApplicantsListTab/ApplicantsListTab.tsx
React를 명시적으로 기본 내보내기로 임포트 문에 추가했습니다.
URL 검증 강화
frontend/src/pages/AdminPage/validation/validateApplicationForm.ts
Google Forms URL 검증을 수정하여 https://docs.google.com/forms/ (후행 슬래시 포함)만 허용하도록 변경했습니다.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

Suggested reviewers

  • lepitaaar
  • Zepelown
  • oesnuj
🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 inconclusive)

Check name Status Explanation Resolution
Title check ❓ Inconclusive PR 제목 '[Fix] v1.1.26 수정'은 구체적인 변경 사항을 명시하지 않은 매우 모호한 표현입니다. 제목을 '상태 검증 로직을 handleStatusChange로 이동' 또는 '상태 변경 시 런타입 검증 강화' 등 구체적이고 설명적인 문구로 수정하여 주 변경 사항을 명확히 전달하세요.
✅ Passed checks (2 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
  • 📝 Generate docstrings (stacked PR)
  • 📝 Generate docstrings (commit on current branch)
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch fix/1.1.26

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Contributor

@lepitaaar lepitaaar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

수고하셨습니다

@seongwon030 seongwon030 merged commit dd0eaba into develop-fe Feb 22, 2026
3 of 4 checks passed
Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹 Nitpick comments (1)
frontend/src/pages/AdminPage/tabs/ApplicantsTab/ApplicantsListTab/ApplicantsListTab.tsx (1)

1-1: [선택적] 기본 React 임포트 대신 named 타입 임포트 사용 권장

import React from 'react'는 JSX 렌더링에는 더 이상 필요하지 않습니다(새 JSX 변환이 필요한 함수를 자동으로 임포트). 그러나 이 파일에서는 React.MouseEvent 타입 참조(Line 92)로 인해 React가 스코프에 필요한 것은 맞습니다.

React 19 + 모던 JSX transform 환경에서는 아래처럼 named 타입 임포트로 대체하는 것이 더 관용적입니다:

♻️ 제안: named 타입 임포트 사용
-import React, { useEffect, useRef, useState } from 'react';
+import { useEffect, useRef, useState, type MouseEvent } from 'react';

그리고 Line 92에서:

-  e: React.MouseEvent,
+  e: MouseEvent,
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.

In
`@frontend/src/pages/AdminPage/tabs/ApplicantsTab/ApplicantsListTab/ApplicantsListTab.tsx`
at line 1, Replace the default React import with a named type import so only
types are kept in scope: remove the top-level "React" default import and instead
import the runtime hooks as before (useEffect, useRef, useState) and add a
type-only import for the MouseEvent type used in the file (the React.MouseEvent
reference in the ApplicantsListTab component). Update any references to
React.MouseEvent to use the imported MouseEvent type (or a local alias) so the
file no longer relies on the default React symbol while preserving the type
usage.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Nitpick comments:
In
`@frontend/src/pages/AdminPage/tabs/ApplicantsTab/ApplicantsListTab/ApplicantsListTab.tsx`:
- Line 1: Replace the default React import with a named type import so only
types are kept in scope: remove the top-level "React" default import and instead
import the runtime hooks as before (useEffect, useRef, useState) and add a
type-only import for the MouseEvent type used in the file (the React.MouseEvent
reference in the ApplicantsListTab component). Update any references to
React.MouseEvent to use the imported MouseEvent type (or a local alias) so the
file no longer relies on the default React symbol while preserving the type
usage.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

💻 FE Frontend 🛠Fix 기능이 의도한 대로 동작하지 않는 버그를 수정

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants