Skip to content

Comments

feat : 사이트 일일 활성사용자수 조회#314

Merged
Zepelown merged 2 commits intodevelop/befrom
feat/#313-dau
Apr 11, 2025
Merged

feat : 사이트 일일 활성사용자수 조회#314
Zepelown merged 2 commits intodevelop/befrom
feat/#313-dau

Conversation

@Due-IT
Copy link
Collaborator

@Due-IT Due-IT commented Apr 9, 2025

  • 상세페이지를 조회한 일일 활성 사용자수를 조회합니다. 이때, 같은 ip는 1로 카운트 됩니다.

#️⃣연관된 이슈

📝작업 내용

- 상세페이지를 조회한 일일 활성 사용자수를 조회합니다. 이때, 같은 ip는 1로 카운트 됩니다.
@Due-IT Due-IT added ✨ Feature 기능 개발 💾 BE Backend labels Apr 9, 2025
@Due-IT Due-IT self-assigned this Apr 9, 2025
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Apr 9, 2025

Important

Review skipped

Auto reviews are disabled on this repository.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai plan to trigger planning for file edits and PR creation.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

Comment on lines 142 to 143
LocalDate targetDate = LocalDate.now().minusDays(i);
dausCount[i] = daus.getOrDefault(targetDate, Collections.emptySet()).size();
Copy link

Copilot AI Apr 9, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider capturing LocalDate.now() once at the start of the method (e.g., as a 'today' variable) to ensure consistency and avoid potential issues if the date changes during method execution.

Suggested change
LocalDate targetDate = LocalDate.now().minusDays(i);
dausCount[i] = daus.getOrDefault(targetDate, Collections.emptySet()).size();
LocalDate targetDate = today.minusDays(i);

Copilot uses AI. Check for mistakes.
@github-actions
Copy link

github-actions bot commented Apr 9, 2025

Test Results

1 tests   1 ✅  0s ⏱️
1 suites  0 💤
1 files    0 ❌

Results for commit 958e208.

♻️ This comment has been updated with latest results.

Copy link
Member

@Zepelown Zepelown left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고생하셨습니다~
Copilot이 설명한대로 minusDays() 부분을 더 보완하면 좋을 것 같아요

@Due-IT
Copy link
Collaborator Author

Due-IT commented Apr 10, 2025

고생하셨습니다~ Copilot이 설명한대로 minusDays() 부분을 더 보완하면 좋을 것 같아요

LocalDate.now()를 today로 선언하여 중복을 제거하였습니다!

그런데 코파일럿이 제안한 코드를 그대로 적용하는 것은 아직 불완전해 보이네요 🤔

@Zepelown
Copy link
Member

고생하셨습니다~ Copilot이 설명한대로 minusDays() 부분을 더 보완하면 좋을 것 같아요

LocalDate.now()를 today로 선언하여 중복을 제거하였습니다!

그런데 코파일럿이 제안한 코드를 그대로 적용하는 것은 아직 불완전해 보이네요 🤔

음.. 이거 또한 상황이 생겨봐야 정확히 알 것 같습니다.

현재로썬 큰 문제가 없어보이긴 합니다.

아무튼 고생하셨습니다!

Copy link
Collaborator

@PororoAndFriends PororoAndFriends left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고생하셨습니다!

@Zepelown Zepelown merged commit 1e719ff into develop/be Apr 11, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

💾 BE Backend ✨ Feature 기능 개발

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants