[refactor] 컨트롤러 분할 등의 리팩토링 진행 by Zepelown · Pull Request #319 · Moadong/moadong

Zepelown · 2025-04-11T06:13:25Z

#️⃣연관된 이슈

#244

📝작업 내용

Club Controller 분리
- ClubController -> ClubProfileController, ClubSearchController
- ClubCommandService -> ClubProfileService
- remove ClubDetailedPageService
키워드 정렬 기준이 봉사,종교,취미교양,학술,운동,공연 순서로 정렬하되 모집중을 우선하여 표시
ClubDetail 관련 클래스, 메소드명 변경
- ClubDetailPageResponse -> ClubDetailResponse
- ClubDetailPageService 삭제

보류

Service가 MongoRepository 직접 참조 문제
- JPA Repository 앞에 추상 계층을 만들면 순환 참조 발생 문제
club 입력값 검증

중점적으로 리뷰받고 싶은 부분

Club Controller 분리에 대한 의견을 받고 싶습니다.

- ClubController -> ClubProfileController, ClubSearchController - ClubCommandService -> ClubProfileService - remove ClubDetailedPageService

- 봉사,종교,취미교양,학술,운동,공연 순서로 정렬

coderabbitai · 2025-04-11T06:13:32Z

Important

Review skipped

Auto reviews are disabled on this repository.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Generate unit testing code for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit testing code for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and generate unit testing code.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai plan to trigger planning for file edits and PR creation.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

github-actions · 2025-04-11T06:14:16Z

Test Results

1 tests 1 ✅ 0s ⏱️
1 suites 0 💤
1 files 0 ❌

Results for commit a2dd02c.

♻️ This comment has been updated with latest results.

PororoAndFriends

저도 ClubController에 너무 기능이 몰려있다 생각했는데 기능에따라 잘 분리된것 같아서 좋네요! 수고하셨습니당

Due-IT

고생하셨습니다 :)

Due-IT · 2025-04-11T14:02:15Z

backend/src/main/java/moadong/club/enums/RecruitmentStatus.java

+    ALWAYS("상시모집", 1),
+    OPEN("모집중", 2),
+    CLOSED("모집마감", 3),
+    UPCOMING("모집예정", 4),


상시모집이 생겼군요 좋습니다 b

Due-IT · 2025-04-11T14:07:21Z

backend/src/main/java/moadong/club/enums/RecruitmentStatus.java

+    RecruitmentStatus(String description, int order) {
        this.description = description;
+        this.order = order;
    }


이 order는 무엇을 의미하나요??

우선 순위를 의미합니다. priority로 바꾸면 더 직관적이겠네요. 바꾸겠습니다.

Due-IT

고생하셨습니다 :)

Zepelown added 5 commits April 10, 2025 23:54

refactor: 클럽 검색을 기존 ClubController에서 분리

105d888

- ClubController -> ClubProfileController, ClubSearchController - ClubCommandService -> ClubProfileService - remove ClubDetailedPageService

refactor: ClubRepostiory, ClubSearchService 안쓰는 메소드 삭제

2c0b51b

refactor: 검색 결과가 봉사, 종교 등의 순으로 정렬되도록 변경

32c4394

- 봉사,종교,취미교양,학술,운동,공연 순서로 정렬

refactor: 상시모집 enum 추가

e8ff769

refactor: 검색 결과가 모집중부터 오도록 변경

9ce8ca7

Zepelown added 📬 API 서버 API 통신 작업 🔨 Refactor 코드 리팩토링 💾 BE Backend labels Apr 11, 2025

Zepelown requested review from Due-IT and PororoAndFriends April 11, 2025 06:13

Zepelown self-assigned this Apr 11, 2025

PororoAndFriends approved these changes Apr 11, 2025

View reviewed changes

Zepelown changed the title ~~[refactor] 컨트롤러 분할, 등의 리팩토링 진행~~ [refactor] 컨트롤러 분할 등의 리팩토링 진행 Apr 11, 2025

Due-IT reviewed Apr 11, 2025

View reviewed changes

Due-IT approved these changes Apr 11, 2025

View reviewed changes

refactor: 검색 정렬 우선 순위 변수명 order -> priority 로 변경

a2dd02c

Zepelown merged commit 35778c8 into develop/be Apr 11, 2025
3 checks passed

Zepelown deleted the refactor/#244-club-feature branch April 11, 2025 16:48

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Comments

[refactor] 컨트롤러 분할 등의 리팩토링 진행#319

[refactor] 컨트롤러 분할 등의 리팩토링 진행#319
Zepelown merged 6 commits intodevelop/befrom
refactor/#244-club-feature

Zepelown commented Apr 11, 2025

Uh oh!

coderabbitai bot commented Apr 11, 2025

Review skipped

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (`.coderabbit.yaml`)

Documentation and Community

Uh oh!

github-actions bot commented Apr 11, 2025 •

edited

Loading

Uh oh!

PororoAndFriends left a comment

Uh oh!

Due-IT left a comment

Uh oh!

Due-IT Apr 11, 2025

Uh oh!

Due-IT Apr 11, 2025

Uh oh!

Zepelown Apr 11, 2025

Uh oh!

Due-IT left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Comments

Conversation

Zepelown commented Apr 11, 2025

#️⃣연관된 이슈

📝작업 내용

중점적으로 리뷰받고 싶은 부분

Uh oh!

coderabbitai bot commented Apr 11, 2025

Review skipped

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

Uh oh!

github-actions bot commented Apr 11, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Test Results

Uh oh!

PororoAndFriends left a comment

Choose a reason for hiding this comment

Uh oh!

Due-IT left a comment

Choose a reason for hiding this comment

Uh oh!

Due-IT Apr 11, 2025

Choose a reason for hiding this comment

Uh oh!

Due-IT Apr 11, 2025

Choose a reason for hiding this comment

Uh oh!

Zepelown Apr 11, 2025

Choose a reason for hiding this comment

Uh oh!

Due-IT left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

CodeRabbit Configuration File (`.coderabbit.yaml`)

github-actions bot commented Apr 11, 2025 •

edited

Loading