[feature] Spinner 컴포넌트 접근성 개선 및 높이 prop 추가 by seongwon030 · Pull Request #391 · Moadong/moadong

seongwon030 · 2025-05-09T08:22:17Z

#️⃣연관된 이슈

ex) #390

📝작업 내용

role="status"와 aria-label 추가로 스크린 리더 지원
height prop 추가로 유연한 높이 조절 가능
SpinnerProps 인터페이스 추가로 타입 안정성 확보

이번 PR에서 작업한 내용을 간략히 설명해주세요(이미지/동영상 첨부 가능)

중점적으로 리뷰받고 싶은 부분(선택)

리뷰어가 특별히 봐주었으면 하는 부분이 있다면 작성해주세요

ex) 메서드 XXX의 이름을 더 잘 짓고 싶은데 혹시 좋은 명칭이 있을까요?

논의하고 싶은 부분(선택)

논의하고 싶은 부분이 있다면 작성해주세요.

🫡 참고사항

Summary by CodeRabbit

신규 기능
- Spinner 컴포넌트에 높이(height) 속성을 선택적으로 지정할 수 있는 기능이 추가되었습니다.
스타일
- Spinner의 기본 높이가 800px에서 100vh로 변경되어 화면에 더 자연스럽게 표시됩니다.
접근성
- Spinner에 접근성 속성(role="status", aria-label="로딩 중")이 추가되어 보조기기 지원이 향상되었습니다.

- role="status"와 aria-label 추가로 스크린 리더 지원 - height prop 추가로 유연한 높이 조절 가능 - SpinnerProps 인터페이스 추가로 타입 안정성 확보

netlify · 2025-05-09T08:22:22Z

✅ Deploy Preview for moadong ready!

Name	Link
🔨 Latest commit	`bb69347`
🔍 Latest deploy log	https://app.netlify.com/sites/moadong/deploys/681dbb3bfc4d860007d1a8ea
😎 Deploy Preview	https://deploy-preview-391--moadong.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.
Lighthouse	1 paths audited Performance: 39 Accessibility: 87 Best Practices: 92 SEO: 92 PWA: - View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

coderabbitai · 2025-05-09T08:22:24Z

Walkthrough

Spinner 컴포넌트에 선택적 height prop과 접근성 속성(role, aria-label)이 추가되었습니다. SpinnerWrapper 스타일 컴포넌트는 height prop을 받아 기본값을 '100vh'로 설정하도록 변경되었습니다. IntroducePage에서 Spinner 사용 시 명시적으로 height를 '800px'로 지정하도록 수정되었습니다.

Changes

파일 경로	변경 요약
frontend/src/components/common/Spinner/Spinner.tsx	Spinner 컴포넌트에 height prop 추가, 접근성 속성(role, aria-label) 추가, 타입 인터페이스 도입
frontend/src/pages/IntroducePage/IntroducePage.tsx	Spinner 사용 시 height를 '800px'로 명시적으로 전달하도록 변경

Sequence Diagram(s)

sequenceDiagram
    participant ParentComponent
    participant Spinner

    ParentComponent->>Spinner: height prop(optional) 전달
    Spinner->>SpinnerWrapper: height prop 전달 (기본값: '100vh')
    SpinnerWrapper->>SpinnerWrapper: role="status", aria-label="로딩 중" 적용

Assessment against linked issues

Objective	Addressed	Explanation
Spinner 컴포넌트 접근성 개선 및 높이 prop 추가 (FE-110)	✅

Possibly related issues

[feature] FE-110 Spinner 컴포넌트 접근성 개선 및 높이 prop 추가 #390: Spinner 컴포넌트의 height prop 추가와 접근성 속성 개선이 동일하게 다뤄지고 있습니다.

Suggested reviewers

oesnuj

Tip

⚡️ Faster reviews with caching

CodeRabbit now supports caching for code and dependencies, helping speed up reviews. This means quicker feedback, reduced wait times, and a smoother review experience overall. Cached data is encrypted and stored securely. This feature will be automatically enabled for all accounts on May 16th. To opt out, configure Review - Disable Cache at either the organization or repository level. If you prefer to disable all data retention across your organization, simply turn off the Data Retention setting under your Organization Settings.

Enjoy the performance boost—your workflow just got faster.

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 79195c5 and bb69347.

📒 Files selected for processing (2)

frontend/src/components/common/Spinner/Spinner.tsx (2 hunks)
frontend/src/pages/IntroducePage/IntroducePage.tsx (1 hunks)

🔇 Additional comments (4)

frontend/src/components/common/Spinner/Spinner.tsx (3)

4-10: 접근성과 유연성을 위한 인터페이스 추가 👍

SpinnerWrapperProps와 SpinnerProps 인터페이스를 추가하여 타입 안전성과 코드 가독성이 향상되었습니다. 선택적 height 속성을 통해 컴포넌트의 유연성이 증가되었습니다.

17-20: 접근성 속성 추가는 훌륭한 개선사항입니다!

role="status"와 aria-label="로딩 중" 속성을 추가하여 스크린 리더 사용자에게 로딩 상태를 명확히 전달할 수 있게 되었습니다. 이것은 웹 접근성 표준(WCAG)을 준수하는 좋은 사례입니다.

24-24: 동적 높이 설정 구현 👍

고정된 높이 대신 props를 통해 동적으로 높이를 설정할 수 있도록 개선되었습니다. 기본값으로 '100vh'를 사용하는 것은 전체 화면 로딩에 적합합니다.

frontend/src/pages/IntroducePage/IntroducePage.tsx (1)

16-16: Spinner 컴포넌트에 명시적 높이 설정

Spinner 컴포넌트에 '800px' 높이를 명시적으로 설정한 것은 좋은 접근입니다. 그러나 이 높이 설정이 실제로 적용되려면 Spinner.tsx 파일에서 height prop이 SpinnerWrapper로 전달되도록 수정해야 합니다.

현재 구현에서는 이 높이 속성이 실제로 적용되지 않을 것입니다. Spinner.tsx 파일 수정 후 정상 작동할 것입니다.

✨ Finishing Touches

📝 Generate Docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Generate unit testing code for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit testing code for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and generate unit testing code.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR.
@coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

oesnuj

접근성 개선 확인이요~

feat: Spinner 컴포넌트 접근성 개선 및 높이 prop 추가

bb69347

- role="status"와 aria-label 추가로 스크린 리더 지원 - height prop 추가로 유연한 높이 조절 가능 - SpinnerProps 인터페이스 추가로 타입 안정성 확보

seongwon030 requested a review from oesnuj May 9, 2025 08:22

seongwon030 self-assigned this May 9, 2025

seongwon030 added ✨ Feature 기능 개발 💻 FE Frontend labels May 9, 2025

seongwon030 linked an issue May 9, 2025 that may be closed by this pull request

[feature] FE-110 Spinner 컴포넌트 접근성 개선 및 높이 prop 추가 #390

Closed

2 tasks

oesnuj approved these changes May 9, 2025

View reviewed changes

seongwon030 merged commit 46c43f8 into develop-fe May 9, 2025
5 checks passed

seongwon030 deleted the feature/#390-spinner-accessibility-FE-110 branch May 9, 2025 08:31

coderabbitai bot mentioned this pull request May 28, 2025

[feature] 소개페이지 컴포넌트 테스트 코드 작성 #448

Merged

coderabbitai bot mentioned this pull request Jun 5, 2025

[feature] 동아리 검색 결과가 없을 시 안내 문구 추가 #495

Merged

coderabbitai bot mentioned this pull request Jul 26, 2025

[refactor] 관리자페이지 로그인 로딩 중 UI를 스피너로 변경한다 #580

Merged

This was referenced Dec 30, 2025

[feature] 공통 컴포넌트 스토리 파일을 제작한다 #889

Merged

[release] v1.1.10 #1006

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[feature] Spinner 컴포넌트 접근성 개선 및 높이 prop 추가#391

[feature] Spinner 컴포넌트 접근성 개선 및 높이 prop 추가#391
seongwon030 merged 1 commit intodevelop-fefrom
feature/#390-spinner-accessibility-FE-110

seongwon030 commented May 9, 2025 •

edited by coderabbitai bot

Loading

Uh oh!

netlify bot commented May 9, 2025 •

edited

Loading

Uh oh!

coderabbitai bot commented May 9, 2025 •

edited

Loading

Chat

Support

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (`.coderabbit.yaml`)

Documentation and Community

Uh oh!

oesnuj left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Comments

Conversation

seongwon030 commented May 9, 2025 • edited by coderabbitai bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

#️⃣연관된 이슈

📝작업 내용

중점적으로 리뷰받고 싶은 부분(선택)

논의하고 싶은 부분(선택)

🫡 참고사항

Summary by CodeRabbit

Uh oh!

netlify bot commented May 9, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Deploy Preview for moadong ready!

Uh oh!

coderabbitai bot commented May 9, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Sequence Diagram(s)

Assessment against linked issues

Possibly related issues

Suggested reviewers

Chat

Support

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

Uh oh!

oesnuj left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Comments

seongwon030 commented May 9, 2025 •

edited by coderabbitai bot

Loading

netlify bot commented May 9, 2025 •

edited

Loading

coderabbitai bot commented May 9, 2025 •

edited

Loading

CodeRabbit Configuration File (`.coderabbit.yaml`)