Skip to content

Comments

[fix] 로그인 시 비밀번호 검증 오류 발생#456

Merged
PororoAndFriends merged 1 commit intodevelop/befrom
fix/#455/password-validation
Jun 1, 2025
Merged

[fix] 로그인 시 비밀번호 검증 오류 발생#456
PororoAndFriends merged 1 commit intodevelop/befrom
fix/#455/password-validation

Conversation

@Zepelown
Copy link
Member

@Zepelown Zepelown commented Jun 1, 2025

#️⃣연관된 이슈

#455

📝작업 내용

비밀번호 검증 시 정확한 비밀번호를 입력했음에도 검증 오류가 발생하는 상황

=> 이전 값으로 롤백처리

중점적으로 리뷰받고 싶은 부분(선택)

리뷰어가 특별히 봐주었으면 하는 부분이 있다면 작성해주세요

ex) 메서드 XXX의 이름을 더 잘 짓고 싶은데 혹시 좋은 명칭이 있을까요?

논의하고 싶은 부분(선택)

논의하고 싶은 부분이 있다면 작성해주세요.

🫡 참고사항

Summary by CodeRabbit

  • 버그 수정
    • 비밀번호 유효성 검사에서 일부 잘못된 문자 제한을 수정하여, 영문자, 숫자, 지정된 특수문자(!@#$%^)를 포함한 8~20자의 비밀번호를 올바르게 허용하도록 개선되었습니다.

@Zepelown Zepelown added 📬 API 서버 API 통신 작업 💾 BE Backend labels Jun 1, 2025
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Jun 1, 2025

Walkthrough

비밀번호 유효성 검증을 위한 정규식 패턴이 수정되었습니다. 기존 패턴에서 불필요한 이스케이프 쿼트와 문자 클래스 제한이 제거되어, 비밀번호에 허용되는 문자의 범위가 확장되었습니다. 검증 로직과 메서드 시그니처는 변경되지 않았습니다.

Changes

파일/경로 변경 요약
backend/src/main/java/moadong/global/validator/PasswordValidator.java 비밀번호 검증 정규식 패턴 수정, 불필요한 문자 및 제한 제거

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between e8ca199 and 7eecc55.

📒 Files selected for processing (1)
  • backend/src/main/java/moadong/global/validator/PasswordValidator.java (1 hunks)
🔇 Additional comments (1)
backend/src/main/java/moadong/global/validator/PasswordValidator.java (1)

11-11: 정규식 패턴이 요구사항을 올바르게 구현하고 있습니다.

수정된 정규식 패턴이 한국어 주석에 명시된 요구사항(8-20자, 영문자·숫자·특수문자 각각 최소 1개)을 정확히 구현하고 있습니다. 패턴의 각 구성 요소가 적절하게 작동하며, 이전에 발생했던 비밀번호 검증 오류를 해결할 것으로 보입니다.

참고: 현재 패턴은 .{8,20} 부분으로 인해 공백이나 기타 문자들도 허용하는 관대한 정책을 사용하고 있습니다. 이는 사용자 편의성을 위한 의도적인 설계로 보입니다.

✨ Finishing Touches
  • 📝 Generate Docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@github-actions
Copy link

github-actions bot commented Jun 1, 2025

Test Results

65 tests   63 ✅  2s ⏱️
11 suites   0 💤
11 files     2 ❌

For more details on these failures, see this check.

Results for commit 7eecc55.

@PororoAndFriends PororoAndFriends merged commit 6b63016 into develop/be Jun 1, 2025
1 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

📬 API 서버 API 통신 작업 💾 BE Backend

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants