Skip to content

Comments

[refactor] index.html의 제목 및 메타 설명 태그 수정#571

Merged
oesnuj merged 2 commits intodevelop-fefrom
refactor/#570-update-html-title
Jul 24, 2025
Merged

[refactor] index.html의 제목 및 메타 설명 태그 수정#571
oesnuj merged 2 commits intodevelop-fefrom
refactor/#570-update-html-title

Conversation

@oesnuj
Copy link
Member

@oesnuj oesnuj commented Jul 24, 2025

#️⃣연관된 이슈

#570

📝작업 내용

이번 PR에서 작업한 내용을 간략히 설명해주세요(이미지/동영상 첨부 가능)

index.html의 <title>과 을 브랜드 및 기능 중심 문장으로 수정했습니다.

Summary by CodeRabbit

  • Style
    • 페이지 타이틀과 메타 태그의 내용이 업데이트되어 브랜드 메시지가 더욱 명확하게 반영되었습니다.
    • Pretendard 및 Krona One 폰트 스타일시트 링크가 <head> 내부로 이동되고, 전체적으로 들여쓰기와 공백이 정리되어 가독성이 향상되었습니다.
    • 메타 및 링크 태그가 한 줄로 간결하게 정리되어 HTML 문서의 일관성과 가독성이 개선되었습니다.

@oesnuj oesnuj self-assigned this Jul 24, 2025
@oesnuj oesnuj added 🔨 Refactor 코드 리팩토링 💻 FE Frontend labels Jul 24, 2025
@netlify
Copy link

netlify bot commented Jul 24, 2025

Deploy Preview for moadong failed.

Name Link
🔨 Latest commit 8adcac4
🔍 Latest deploy log https://app.netlify.com/projects/moadong/deploys/6881ce0bbfadcf0008ca83b5

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Jul 24, 2025

Warning

.coderabbit.yaml has a parsing error

The CodeRabbit configuration file in this repository has a parsing error and default settings were used instead. Please fix the error(s) in the configuration file. You can initialize chat with CodeRabbit to get help with the configuration file.

💥 Parsing errors (1)
Validation error: Invalid regex pattern for base branch. Received: "**" at "reviews.auto_review.base_branches[0]"
⚙️ Configuration instructions
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

"""

Walkthrough

index.html 파일의 head 섹션이 리포맷되고, 제목과 메타 태그의 내용이 변경되었습니다. 페이지 타이틀과 설명이 한글로 수정되었고, 오픈그래프 및 트위터 카드 메타 태그의 내용도 최신 브랜딩에 맞게 조정되었습니다. 구조와 들여쓰기도 일관성 있게 정리되었습니다.

Changes

파일/경로 변경 요약
frontend/public/index.html head 섹션 리포맷, 타이틀 및 메타 태그 한글화, 브랜딩 메시지 수정, 들여쓰기 및 구조 정리

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Possibly related issues

Possibly related PRs

Note

⚡️ Unit Test Generation is now available in beta!

Learn more here, or try it out under "Finishing Touches" below.


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between ea95af2 and 8adcac4.

📒 Files selected for processing (1)
  • frontend/public/index.html (2 hunks)
🚧 Files skipped from review as they are similar to previous changes (1)
  • frontend/public/index.html
✨ Finishing Touches
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch refactor/#570-update-html-title

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai generate unit tests to generate unit tests for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (3)
frontend/public/index.html (3)

10-12: 타이틀·디스크립션 한국어만 포함 → 다국어 SEO 보완 제안
검색엔진·SNS 썸네일에서 영문 키워드(예: “Moadong”)가 전혀 포함되지 않아 해외 검색 노출이 어려울 수 있습니다. 브랜드 영문명을 뒤쪽에 덧붙여 보세요.

-<title>모아동 - 부경대학교 모든 동아리를 한눈에</title>
+<title>모아동(Moadong) - 부경대학교 모든 동아리를 한눈에</title>

동일한 맥락으로 meta name="description"에도 영문 키워드를 1-2개 포함하면 좋습니다.


18-22: OG 태그와 페이지 타이틀 불일치
og:title이 단순히 “모아동”으로만 설정되어 있어 페이지 <title>에 비해 정보량이 부족합니다. SNS 공유 시 브랜드 메시지가 축약되어 전달될 위험이 있습니다.

-<meta property="og:title" content="모아동" />
+<meta property="og:title" content="모아동 - 부경대학교 모든 동아리를 한눈에" />

동일한 값으로 맞춰두면 썸네일·브라우저 탭 간 일관성이 향상됩니다.


28-30: Twitter 카드 텍스트 형식 통일
twitter:title이 실제 페이지 제목 대신 슬로건 형태로 들어가 있습니다. 트위터와 OG 간 제목이 다르면 공유 썸네일 문구가 플랫폼별로 달라지는 점을 고려해 통일을 권장합니다.

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 4f8e3a8 and ea95af2.

📒 Files selected for processing (1)
  • frontend/public/index.html (1 hunks)
🧰 Additional context used
🧠 Learnings (1)
frontend/public/index.html (1)

Learnt from: seongwon030
PR: #541
File: frontend/src/pages/ClubDetailPage/components/ClubDetailHeader/ClubDetailHeader.tsx:41-43
Timestamp: 2025-07-20T11:48:50.207Z
Learning: moadong 프로젝트는 Next.js가 아닌 순수 React + react-router-dom 기반의 CSR(Client-Side Rendering) SPA이므로, window 객체 사용에 대한 SSR 호환성 문제를 제기하지 않아야 합니다.

🔇 Additional comments (1)
frontend/public/index.html (1)

4-9: 메타 태그 위치 및 기본 설정 적절
charset, X-UA-Compatible, viewport 등 필수 메타 태그가 <head> 최상단에 올바르게 배치되어 있습니다. CSR SPA에서 호환성·반응형을 보장하는 데 필요한 최소 구성이 잘 유지되었습니다.

Copy link
Member

@seongwon030 seongwon030 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

title 변경 좋네요

@oesnuj oesnuj merged commit e65a1ba into develop-fe Jul 24, 2025
3 checks passed
@oesnuj oesnuj deleted the refactor/#570-update-html-title branch July 28, 2025 06:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

💻 FE Frontend 🔨 Refactor 코드 리팩토링

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants