Skip to content

Comments

관리자 페이지 UI/UX 개선 및 버그 수정 (모집대상 텍스트, 탭 경고, 로고 업로드)#587

Merged
oesnuj merged 5 commits intodevelop-fefrom
feature/#584-admin-ui-enhancements-MOA-110
Jul 27, 2025
Merged

관리자 페이지 UI/UX 개선 및 버그 수정 (모집대상 텍스트, 탭 경고, 로고 업로드)#587
oesnuj merged 5 commits intodevelop-fefrom
feature/#584-admin-ui-enhancements-MOA-110

Conversation

@oesnuj
Copy link
Member

@oesnuj oesnuj commented Jul 26, 2025

#️⃣연관된 이슈

ex) #584

📝작업 내용

이번 PR에서 작업한 내용을 간략히 설명해주세요(이미지/동영상 첨부 가능)

1. 모집 대상 라벨 수정

  • 기존: 오집대상설정
  • 변경: 모집 대상

2. 동아리 로고 업로드 개선

  • 같은 이미지 선택 시 업로드 안 되는 문제 해결
  • input[type="file"]value를 직접 비워서 onChange 이벤트가 다시 발생하도록 처리 (e.target.value = '')

Summary by CodeRabbit

  • 버그 수정

    • 동일한 파일을 다시 선택할 때 파일 선택이 정상적으로 감지되도록 파일 입력값이 초기화되었습니다.
  • 스타일

    • 일부 버튼의 코드 포맷이 일관성 있게 정리되었습니다.
    • 모집 마감 관련 버튼 컴포넌트의 코드가 간결하게 개선되었습니다.
  • 문서화

    • 모집 대상 입력 필드의 라벨이 "모집 대상 설정"에서 "모집 대상"으로 변경되었습니다.
  • 기타

    • 컴포넌트 이름이 AnswerApplicationForm에서 ApplicationFormPage로 변경되었습니다.

@oesnuj oesnuj requested review from lepitaaar and seongwon030 July 26, 2025 09:12
@oesnuj oesnuj self-assigned this Jul 26, 2025
@oesnuj oesnuj added 💻 FE Frontend 🛠Fix 기능이 의도한 대로 동작하지 않는 버그를 수정 labels Jul 26, 2025
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Jul 26, 2025

Warning

.coderabbit.yaml has a parsing error

The CodeRabbit configuration file in this repository has a parsing error and default settings were used instead. Please fix the error(s) in the configuration file. You can initialize chat with CodeRabbit to get help with the configuration file.

💥 Parsing errors (1)
Validation error: Invalid regex pattern for base branch. Received: "**" at "reviews.auto_review.base_branches[0]"
⚙️ Configuration instructions
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

"""

Walkthrough

이 변경사항은 관리자 페이지의 UI/UX를 개선하기 위해 ClubLogoEditor 컴포넌트의 파일 입력 처리 로직을 수정하고, RecruitEditTab의 모집 대상 입력 필드 라벨을 변경합니다. 추가로 ClubLogoEditor 내 일부 JSX의 포맷이 일관성 있게 조정되었습니다. 또한, 여러 파일에서 parseRecruitmentPeriod 관련 import 경로의 .ts 확장자를 제거하고, ClubApplyButton 컴포넌트의 JSX 표현을 단순화했습니다. ApplicationFormPage 컴포넌트 이름도 변경되었습니다.

Changes

파일/경로 변경 요약
frontend/src/pages/AdminPage/components/ClubLogoEditor/ClubLogoEditor.tsx 파일 선택 후 input value를 초기화하여 동일 파일 재선택 가능하게 수정, 일부 JSX 포맷 정리
frontend/src/pages/AdminPage/tabs/RecruitEditTab/RecruitEditTab.tsx 모집 대상 입력 필드 라벨 텍스트를 "모집 대상 설정"에서 "모집 대상"으로 변경
frontend/src/pages/ClubDetailPage/components/ClubDetailFooter/ClubDetailFooter.tsx, parseRecruitmentPeriod import 경로에서 .ts 확장자 제거, ClubApplyButton JSX 단일 라인으로 정리
frontend/src/pages/ClubDetailPage/components/ClubDetailHeader/ClubDetailHeader.tsx
frontend/src/utils/parseRecruitmentPeriod.test.ts, parseRecruitmentPeriod 및 parseRecruitmentDateString import 경로에서 .ts 확장자 제거
frontend/src/utils/recruitmentPeriodParser.test.ts
frontend/src/pages/ApplicationFormPage/ApplicationFormPage.tsx 컴포넌트명 AnswerApplicationForm에서 ApplicationFormPage로 변경 및 기본 내보내기 수정

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Possibly related issues

Possibly related PRs

Suggested labels

🎨 Design
"""

Note

⚡️ Unit Test Generation is now available in beta!

Learn more here, or try it out under "Finishing Touches" below.


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 0fd098b and d391242.

📒 Files selected for processing (1)
  • frontend/src/pages/ApplicationFormPage/ApplicationFormPage.tsx (2 hunks)
✅ Files skipped from review due to trivial changes (1)
  • frontend/src/pages/ApplicationFormPage/ApplicationFormPage.tsx
✨ Finishing Touches
  • 📝 Generate Docstrings
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch feature/#584-admin-ui-enhancements-MOA-110

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai generate unit tests to generate unit tests for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@netlify
Copy link

netlify bot commented Jul 26, 2025

Deploy Preview for moadong ready!

Name Link
🔨 Latest commit d391242
🔍 Latest deploy log https://app.netlify.com/projects/moadong/deploys/6884a0239b257c0008467ac9
😎 Deploy Preview https://deploy-preview-587--moadong.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 39
Accessibility: 89
Best Practices: 92
SEO: 92
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify project configuration.

Copy link
Member

@seongwon030 seongwon030 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@lepitaaar lepitaaar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

심리적 안정감 증가

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

💻 FE Frontend 🛠Fix 기능이 의도한 대로 동작하지 않는 버그를 수정

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants