Skip to content

[feature] 공유버튼을 카카오톡 이미지로 변경한다#597

Merged
seongwon030 merged 1 commit intodevelop-fefrom
feat/#596-change-kakao-share-button-image-MOA-120
Jul 27, 2025
Merged

[feature] 공유버튼을 카카오톡 이미지로 변경한다#597
seongwon030 merged 1 commit intodevelop-fefrom
feat/#596-change-kakao-share-button-image-MOA-120

Conversation

@seongwon030
Copy link
Member

@seongwon030 seongwon030 commented Jul 27, 2025

#️⃣연관된 이슈

ex) #596

📝작업 내용

이번 PR에서 작업한 내용을 간략히 설명해주세요(이미지/동영상 첨부 가능)

중점적으로 리뷰받고 싶은 부분(선택)

리뷰어가 특별히 봐주었으면 하는 부분이 있다면 작성해주세요

ex) 메서드 XXX의 이름을 더 잘 짓고 싶은데 혹시 좋은 명칭이 있을까요?

논의하고 싶은 부분(선택)

논의하고 싶은 부분이 있다면 작성해주세요.

🫡 참고사항

Summary by CodeRabbit

  • Style
    • 공유 버튼의 아이콘이 기존 SVG에서 새로운 PNG 이미지로 변경되었습니다.

@netlify
Copy link

netlify bot commented Jul 27, 2025

Deploy Preview for moadong ready!

Name Link
🔨 Latest commit 9c4508c
🔍 Latest deploy log https://app.netlify.com/projects/moadong/deploys/68863422c185cf00081226ba
😎 Deploy Preview https://deploy-preview-597--moadong.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 40
Accessibility: 89
Best Practices: 92
SEO: 92
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify project configuration.

@vercel
Copy link

vercel bot commented Jul 27, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
moadong ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 27, 2025 2:13pm

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Jul 27, 2025

Warning

.coderabbit.yaml has a parsing error

The CodeRabbit configuration file in this repository has a parsing error and default settings were used instead. Please fix the error(s) in the configuration file. You can initialize chat with CodeRabbit to get help with the configuration file.

💥 Parsing errors (1)
Validation error: Invalid regex pattern for base branch. Received: "**" at "reviews.auto_review.base_branches[0]"
⚙️ Configuration instructions
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Walkthrough

ShareButton 컴포넌트에서 사용하던 기존의 SVG 공유 아이콘(share_icon.svg)이 카카오톡 공유 버튼용 PNG 이미지(kakaotalk_sharing_btn_small.png)로 교체되었습니다. <img> 태그의 소스도 새 PNG 이미지로 변경되었으며, 그 외의 로직이나 기능적 변화는 없습니다.

Changes

파일 경로 변경 요약
frontend/src/pages/ClubDetailPage/components/ShareButton/ShareButton.tsx 공유 아이콘 이미지를 SVG에서 카카오톡 PNG로 교체

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Possibly related issues

Possibly related PRs

Suggested labels

✨ Feature, 💻 FE

✨ Finishing Touches
  • 📝 Generate Docstrings
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch feat/#596-change-kakao-share-button-image-MOA-120

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai generate unit tests to generate unit tests for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@seongwon030 seongwon030 added ✨ Feature 기능 개발 💻 FE Frontend labels Jul 27, 2025
@seongwon030 seongwon030 linked an issue Jul 27, 2025 that may be closed by this pull request
2 tasks
Copy link
Member

@Zepelown Zepelown left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고생하셨습니다!

Copy link
Contributor

@lepitaaar lepitaaar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

카카오톡 이미지 애매하네요

@seongwon030 seongwon030 merged commit ecddc53 into develop-fe Jul 27, 2025
8 of 9 checks passed
@seongwon030 seongwon030 deleted the feat/#596-change-kakao-share-button-image-MOA-120 branch July 27, 2025 14:16
Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (2)
frontend/src/pages/ClubDetailPage/components/ShareButton/ShareButton.tsx (2)

5-5: PNG 리소스 import 시 번들 크기‧경로 관리도 함께 고려하세요
PNG 파일을 import 하면 Webpack/ESBuild가 에셋을 번들에 포함시키거나 별도 파일로 복사합니다. 이미지가 정적(변경될 일 없음)이고 Next.js 등 정적 폴더(/public)를 사용하는 스택이라면

<img src="/images/kakaotalk_sharing_btn_small.png"  />

처럼 경로 문자열을 쓰는 편이 번들 크기를 줄이고 캐시 활용에 유리합니다. 빌드 파이프라인과 캐싱 전략을 다시 한 번 점검해 보세요.


50-56: 시맨틱‧키보드 접근성을 위해 <button> 요소 사용 권장

현재 Styled.ShareButtonContainer는 div + role="button" 패턴입니다. 시맨틱 표준 button을 쓰면

  • 기본적으로 tabIndex, Space/Enter 키 입력 처리, 포커스 아웃라인 등이 자동 제공
  • ARIA 역할을 따로 지정할 필요가 없음

또한 <img> 태그에 loading="lazy"를 추가하면 초기 렌더링 최적화에도 도움이 됩니다.

예시 diff:

-<Styled.ShareButtonContainer
-  onClick={handleShare}
-  role='button'
-  aria-label='카카오톡으로 동아리 정보 공유하기'
->
+<Styled.ShareButtonContainer
+  as="button"
+  type="button"
+  onClick={handleShare}
+  aria-label="카카오톡으로 동아리 정보 공유하기"
+>
   <img src={KakaoIcon} alt='카카오톡 공유' loading='lazy' />
 </Styled.ShareButtonContainer>
📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 8eac281 and 9c4508c.

⛔ Files ignored due to path filters (1)
  • frontend/src/assets/images/icons/kakaotalk_sharing_btn_small.png is excluded by !**/*.png
📒 Files selected for processing (1)
  • frontend/src/pages/ClubDetailPage/components/ShareButton/ShareButton.tsx (2 hunks)
🧰 Additional context used
📓 Path-based instructions (2)
frontend/**/*.{ts,tsx}

📄 CodeRabbit Inference Engine (frontend/.cursorrules)

frontend/**/*.{ts,tsx}: Replace magic numbers with named constants for clarity.
Replace complex or nested ternary operators with if/else statements or IIFEs for readability.
Assign complex boolean conditions to named variables.
Use consistent return types for similar functions and hooks.
Avoid hidden side effects; functions should only perform actions implied by their signature (Single Responsibility Principle).
Use unique, descriptive names for custom wrappers and functions to avoid ambiguity.
Define constants near related logic or ensure names link them clearly.

Files:

  • frontend/src/pages/ClubDetailPage/components/ShareButton/ShareButton.tsx
frontend/**/*.tsx

📄 CodeRabbit Inference Engine (frontend/.cursorrules)

frontend/**/*.tsx: Abstract complex logic/interactions into dedicated components or higher-order components (HOCs).
Separate significantly different conditional UI/logic into distinct components.
Colocate simple, localized logic or use inline definitions to reduce context switching.
Choose field-level or form-level cohesion based on form requirements.
Break down broad state management into smaller, focused hooks or contexts.
Use component composition instead of props drilling.

Files:

  • frontend/src/pages/ClubDetailPage/components/ShareButton/ShareButton.tsx

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

💻 FE Frontend ✨ Feature 기능 개발

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[feat] MOA-120 공유버튼을 카카오톡 이미지로 변경한다

3 participants

Comments