Skip to content

[release]모아동 BE v1.0.5 배포 #608

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lepitaaar merged 2 commits into from
Jul 28, 2025
Merged

[release]모아동 BE v1.0.5 배포 #608

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
656e832
feat: 외부 지원서 링크 추가
Zepelown Jul 28, 2025
2ff5a8d
Merge pull request #606 from Moadong/feature/#604-external-applicatio…
Zepelown Jul 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions backend/src/main/java/moadong/club/entity/ClubRecruitmentInformation.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,6 +54,8 @@ public class ClubRecruitmentInformation {

private String recruitmentTarget;

String externalApplicationUrl;

private List<String> feedImages;

private List<String> tags;
Expand All @@ -77,6 +79,7 @@ public void updateDescription(ClubRecruitmentInfoUpdateRequest request) {
this.recruitmentStart = request.recruitmentStart();
this.recruitmentEnd = request.recruitmentEnd();
this.recruitmentTarget = request.recruitmentTarget();
this.externalApplicationUrl = request.externalApplicationUrl();
this.faqs = request.faqs();
}

Expand Down
3 changes: 3 additions & 0 deletions backend/src/main/java/moadong/club/payload/dto/ClubDetailedResult.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,7 @@ public record ClubDetailedResult(
String recruitmentPeriod,
String recruitmentTarget,
String recruitmentStatus,
String externalApplicationUrl,
Map<String, String> socialLinks,
String category,
String division,
Expand Down Expand Up @@ -67,6 +68,8 @@ public static ClubDetailedResult of(Club club) {
: clubRecruitmentInformation.getRecruitmentTarget())
.recruitmentStatus(clubRecruitmentInformation.getClubRecruitmentStatus() == null
? "" : clubRecruitmentInformation.getClubRecruitmentStatus().getDescription())
.externalApplicationUrl(club.getClubRecruitmentInformation().getExternalApplicationUrl()== null ? "" :
club.getClubRecruitmentInformation().getExternalApplicationUrl())
Comment on lines +71 to +72
Copy link
Contributor

@coderabbitai coderabbitai bot Jul 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🛠️ Refactor suggestion

코드 포맷팅 수정 및 일관성 개선이 필요합니다.

몇 가지 개선점이 있습니다:

  1. == null 앞에 공백이 누락되었습니다
  2. 다른 필드들과 달리 로컬 변수 clubRecruitmentInformation을 사용하지 않아 일관성이 떨어집니다
  3. 동일한 메서드를 두 번 호출하는 중복이 있습니다
-                .externalApplicationUrl(club.getClubRecruitmentInformation().getExternalApplicationUrl()== null ? "" :
-                        club.getClubRecruitmentInformation().getExternalApplicationUrl())
+            .externalApplicationUrl(clubRecruitmentInformation.getExternalApplicationUrl() == null ? ""
+                : clubRecruitmentInformation.getExternalApplicationUrl())
🤖 Prompt for AI Agents 
In backend/src/main/java/moadong/club/payload/dto/ClubDetailedResult.java around
lines 71 to 72, fix the formatting by adding a space before '== null' for
readability, use a local variable to store club.getClubRecruitmentInformation()
to maintain consistency with other fields, and avoid calling
getExternalApplicationUrl() twice by reusing the local variable. This will
improve code clarity and reduce redundant method calls.

.socialLinks(club.getSocialLinks() == null ? Map.of()
: club.getSocialLinks())
.faqs(club.getClubRecruitmentInformation().getFaqs() == null ? List.of()
Expand Down
1 change: 1 addition & 0 deletions backend/src/main/java/moadong/club/payload/request/ClubRecruitmentInfoUpdateRequest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@ public record ClubRecruitmentInfoUpdateRequest(
LocalDateTime recruitmentEnd,
String recruitmentTarget,
String description,
String externalApplicationUrl,
List<Faq> faqs
) {

Expand Down