Skip to content

RecruitEditTab에서 외부 지원서 URL을 업데이트하는 로직 추가 #610

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lepitaaar merged 1 commit into from
Jul 30, 2025
Merged

RecruitEditTab에서 외부 지원서 URL을 업데이트하는 로직 추가 #610

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions frontend/src/pages/AdminPage/tabs/RecruitEditTab/RecruitEditTab.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,6 +43,7 @@ const RecruitEditTab = () => {
recruitmentEnd: recruitmentEnd?.toISOString(),
recruitmentTarget: recruitmentTarget,
description: description,
externalApplicationUrl: clubDetail.externalApplicationUrl ?? ''
Copy link
Contributor

@coderabbitai coderabbitai bot Jul 30, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue

외부 지원서 URL 편집을 위한 UI 컴포넌트가 누락되었습니다.

externalApplicationUrl 속성이 updatedData에 추가되었지만, 사용자가 이 값을 편집할 수 있는 UI 컴포넌트(예: InputField)가 JSX에 없습니다. 현재 구현으로는 기존 값만 다시 전송되며, 실제로 URL을 수정할 수 없습니다.

다음과 같이 외부 지원서 URL을 편집할 수 있는 입력 필드를 추가해야 합니다:

  const [recruitmentTarget, setRecruitmentTarget] = useState('');
  const [description, setDescription] = useState('');
+ const [externalApplicationUrl, setExternalApplicationUrl] = useState('');
    setRecruitmentTarget((prev) => prev || clubDetail.recruitmentTarget || '');
    setDescription((prev) => prev || clubDetail.description || '');
+   setExternalApplicationUrl((prev) => prev || clubDetail.externalApplicationUrl || '');
      externalApplicationUrl: clubDetail.externalApplicationUrl ?? ''
+     externalApplicationUrl: externalApplicationUrl
        <InputField
          label='모집 대상'
          placeholder='모집 대상을 입력해주세요.'
          type='text'
          value={recruitmentTarget}
          onChange={(e) => setRecruitmentTarget(e.target.value)}
          onClear={() => setRecruitmentTarget('')}
          maxLength={10}
        />
+       <InputField
+         label='외부 지원서 URL'
+         placeholder='외부 지원서 URL을 입력해주세요.'
+         type='url'
+         value={externalApplicationUrl}
+         onChange={(e) => setExternalApplicationUrl(e.target.value)}
+         onClear={() => setExternalApplicationUrl('')}
+       />

Committable suggestion skipped: line range outside the PR's diff.

🤖 Prompt for AI Agents 
In frontend/src/pages/AdminPage/tabs/RecruitEditTab/RecruitEditTab.tsx at line
46, the externalApplicationUrl field is included in updatedData but there is no
input component in the JSX to allow users to edit this URL. To fix this, add an
input field component (such as an InputField) bound to externalApplicationUrl in
the form JSX so users can modify the URL. Ensure the input updates the
corresponding state or form data to reflect user changes.

};
updateClubDescription(updatedData, {
onSuccess: () => {
Expand Down