Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Contributor
|
Warning
|
| Cohort / File(s) | Change Summary |
|---|---|
DTO: ClubApplicantsResultbackend/src/main/java/moadong/club/payload/dto/ClubApplicantsResult.java |
레코드 시그니처에 memo(String) 필드 추가; of(...) 팩토리 메서드에서 application.getMemo()를 통해 memo 설정; 기타 로직(AES 오류 처리 등) 변경 없음 |
Estimated code review effort
🎯 1 (Trivial) | ⏱️ ~3 minutes
Possibly related issues
- [feature] MOA-141 지원 현황 API 메모 추가 #634: 지원자/응답 API에 memo 필드 추가와 동일한 DTO 변경을 요구하여 본 변경과 직접적으로 연관됩니다.
Possibly related PRs
- [feature] 지원서의 메모를 수정할 수 있다. #620: ClubApplicantsResult에 memo 노출을 도입/수정하는 동일 클래스 변경으로 코드 수준에서 직접 연관됩니다.
✨ Finishing Touches
- 📝 Generate Docstrings
🧪 Generate unit tests
- Create PR with unit tests
- Post copyable unit tests in a comment
- Commit unit tests in branch
feature/applicant-summary-memo-add
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
🪧 Tips
Chat
There are 3 ways to chat with CodeRabbit:
- Review comments: Directly reply to a review comment made by CodeRabbit. Example:
I pushed a fix in commit <commit_id>, please review it.Explain this complex logic.Open a follow-up GitHub issue for this discussion.
- Files and specific lines of code (under the "Files changed" tab): Tag
@coderabbitaiin a new review comment at the desired location with your query. Examples:@coderabbitai explain this code block.
- PR comments: Tag
@coderabbitaiin a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:@coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.@coderabbitai read src/utils.ts and explain its main purpose.@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
Support
Need help? Create a ticket on our support page for assistance with any issues or questions.
CodeRabbit Commands (Invoked using PR comments)
@coderabbitai pauseto pause the reviews on a PR.@coderabbitai resumeto resume the paused reviews.@coderabbitai reviewto trigger an incremental review. This is useful when automatic reviews are disabled for the repository.@coderabbitai full reviewto do a full review from scratch and review all the files again.@coderabbitai summaryto regenerate the summary of the PR.@coderabbitai generate docstringsto generate docstrings for this PR.@coderabbitai generate sequence diagramto generate a sequence diagram of the changes in this PR.@coderabbitai generate unit teststo generate unit tests for this PR.@coderabbitai resolveresolve all the CodeRabbit review comments.@coderabbitai configurationto show the current CodeRabbit configuration for the repository.@coderabbitai helpto get help.
Other keywords and placeholders
- Add
@coderabbitai ignoreanywhere in the PR description to prevent this PR from being reviewed. - Add
@coderabbitai summaryto generate the high-level summary at a specific location in the PR description. - Add
@coderabbitaianywhere in the PR title to generate the title automatically.
Documentation and Community
- Visit our Documentation for detailed information on how to use CodeRabbit.
- Join our Discord Community to get help, request features, and share feedback.
- Follow us on X/Twitter for updates and announcements.
Test Results75 tests 75 ✅ 2s ⏱️ Results for commit e99b2a0. |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
backend/src/main/java/moadong/club/payload/dto/ClubApplicantsResult.java (1)
22-22: ClubApplicantsResult 레코드 시그니처 변경 — 직접 생성자 호출 없음(추가 검증 권장)
rg -n 'new ClubApplicantsResult'검색 결과 단일 라인 호출은 없었습니다.
멀티라인 괄호 사용 시 탐색되지 않을 수 있으므로, 수동으로 직접 생성자 호출부를 검토해 주세요.- OpenAPI 스키마(백엔드 @Schema, Swagger)와 프론트엔드 DTO가 신규
memo필드를 반영하는지 확인이 필요합니다.- Jackson 전역 설정이나 필드별
@JsonInclude로null직렬화 정책이 의도와 일치하는지 점검해 주세요.memo가 PII/민감정보인지, 저장 시 암호화되어 있다면 복호화 로직(try-catch) 추가를 검토해 주세요.스키마 문서화를 위한 예시 제안(diff):
+import io.swagger.v3.oas.annotations.media.Schema; @@ - String memo, + @Schema(description = "지원서 메모(관리자용)") String memo,
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
backend/src/main/java/moadong/club/payload/dto/ClubApplicantsResult.java(2 hunks)
🔇 Additional comments (1)
backend/src/main/java/moadong/club/payload/dto/ClubApplicantsResult.java (1)
44-44: memo는 평문 저장 정책이며 별도 복호화 불필요, 접근 제어도 적절합니다
- ClubApplication 엔티티의
memo필드는 JPA 속성 변환기나 암호화 어노테이션 없이 평문으로 저장됩니다.ClubApplicantsResult.of(…)에서 AESCipher는answers값만 복호화하도록 설계되어 있고,memo는 평문 그대로 사용됩니다./api/club/{clubId}/apply/info엔드포인트는 Spring Security 인증(@PreAuthorize("isAuthenticated()")) 후 서비스 레이어(getClubApplyInfo)에서 클럽 소유자만 접근하도록 추가 권한 검증(user.getId().equals(club.getUserId()))을 수행하므로 PII 노출 위험이 없습니다.
따라서 현재 구현을 유지하셔도 무방합니다.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#️⃣연관된 이슈
#634
📝작업 내용
저번 작업에 빼먹었던 필드 추가했습니다 ㅜ
중점적으로 리뷰받고 싶은 부분(선택)
논의하고 싶은 부분(선택)
🫡 참고사항
Summary by CodeRabbit