Skip to content

Comments

[feature] 메인페이지 배너를 변경한다#741

Merged
suhyun113 merged 2 commits intodevelop-fefrom
feature/#740-change-mainpage-banner-MOA-233
Sep 18, 2025
Merged

[feature] 메인페이지 배너를 변경한다#741
suhyun113 merged 2 commits intodevelop-fefrom
feature/#740-change-mainpage-banner-MOA-233

Conversation

@suhyun113
Copy link
Collaborator

#️⃣연관된 이슈

ex) #740

📝작업 내용

메인페이지 배너 변경

image image

모바일 메인페이지 배너 변경

image image

중점적으로 리뷰받고 싶은 부분(선택)

리뷰어가 특별히 봐주었으면 하는 부분이 있다면 작성해주세요

ex) 메서드 XXX의 이름을 더 잘 짓고 싶은데 혹시 좋은 명칭이 있을까요?

논의하고 싶은 부분(선택)

논의하고 싶은 부분이 있다면 작성해주세요.

🫡 참고사항

@suhyun113 suhyun113 self-assigned this Sep 17, 2025
@suhyun113 suhyun113 added 🎨 Design 마크업 & 스타일링 💻 FE Frontend labels Sep 17, 2025
@vercel
Copy link

vercel bot commented Sep 17, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
moadong Ready Ready Preview Comment Sep 17, 2025 4:21pm

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Sep 17, 2025

Important

Review skipped

Review was skipped due to path filters

⛔ Files ignored due to path filters (4)
  • frontend/src/assets/images/banners/banner_desktop1.png is excluded by !**/*.png
  • frontend/src/assets/images/banners/banner_desktop2.png is excluded by !**/*.png
  • frontend/src/assets/images/banners/banner_mobile1.png is excluded by !**/*.png
  • frontend/src/assets/images/banners/banner_mobile2.png is excluded by !**/*.png

CodeRabbit blocks several paths by default. You can override this behavior by explicitly including those paths in the path filters. For example, including **/dist/** will override the default block on the dist directory, by removing the pattern from both the lists.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Warning

.coderabbit.yaml has a parsing error

The CodeRabbit configuration file in this repository has a parsing error and default settings were used instead. Please fix the error(s) in the configuration file. You can initialize chat with CodeRabbit to get help with the configuration file.

💥 Parsing errors (1)
Validation error: Invalid regex pattern for base branch. Received: "**" at "reviews.auto_review.base_branches[0]"
⚙️ Configuration instructions
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json
✨ Finishing touches
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch feature/#740-change-mainpage-banner-MOA-233

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Contributor

@lepitaaar lepitaaar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

수고하셨습니다 코드가 바뀔줄알았는데 사진만 변경되었군요 ㅋㅋㅋ

Copy link
Member

@seongwon030 seongwon030 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

배너 변경 좋아요~

@seongwon030
Copy link
Member

수고하셨습니다 코드가 바뀔줄알았는데 사진만 변경되었군요 ㅋㅋㅋ

오히려 좋아 용량 그대로

@suhyun113 suhyun113 merged commit b1ee1de into develop-fe Sep 18, 2025
5 checks passed
@lepitaaar lepitaaar deleted the feature/#740-change-mainpage-banner-MOA-233 branch October 21, 2025 08:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🎨 Design 마크업 & 스타일링 💻 FE Frontend

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants