Skip to content

[cicd] firebase.json 추가#814

Merged
lepitaaar merged 1 commit intodevelop/befrom
cicd/add-firebase-config
Nov 9, 2025
Merged

[cicd] firebase.json 추가#814
lepitaaar merged 1 commit intodevelop/befrom
cicd/add-firebase-config

Conversation

@lepitaaar
Copy link
Contributor

@lepitaaar lepitaaar commented Nov 9, 2025

#️⃣연관된 이슈

ex) #이슈번호, #이슈번호

📝작업 내용

release, develop 배포 실패를 고쳤습니다

중점적으로 리뷰받고 싶은 부분(선택)

리뷰어가 특별히 봐주었으면 하는 부분이 있다면 작성해주세요

ex) 메서드 XXX의 이름을 더 잘 짓고 싶은데 혹시 좋은 명칭이 있을까요?

논의하고 싶은 부분(선택)

논의하고 싶은 부분이 있다면 작성해주세요.

🫡 참고사항

Summary by CodeRabbit

릴리스 노트

  • Chores
    • CI/CD 파이프라인 최적화 및 안정성 개선
    • 빌드 캐싱을 통한 배포 프로세스 성능 향상
    • 설정 관리 자동화로 배포 신뢰성 강화
    • 워크플로우 구조 및 형식 개선

@lepitaaar lepitaaar self-assigned this Nov 9, 2025
@lepitaaar lepitaaar added 💾 BE Backend 📦 CI/CD CI/CD 관련 설정 및 유지보수 labels Nov 9, 2025
@vercel
Copy link

vercel bot commented Nov 9, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
moadong Ready Ready Preview Comment Nov 9, 2025 5:51am

@lepitaaar lepitaaar merged commit 24c4822 into develop/be Nov 9, 2025
3 checks passed
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Nov 9, 2025

Caution

Review failed

The pull request is closed.

Warning

.coderabbit.yaml has a parsing error

The CodeRabbit configuration file in this repository has a parsing error and default settings were used instead. Please fix the error(s) in the configuration file. You can initialize chat with CodeRabbit to get help with the configuration file.

💥 Parsing errors (1)
Validation error: Invalid regex pattern for base branch. Received: "**" at "reviews.auto_review.base_branches[0]"
⚙️ Configuration instructions
  • Please see the configuration documentation for more information.
  • You can also validate your configuration using the online YAML validator.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Walkthrough

GitHub Actions 워크플로우 두 개에서 YAML 문자열 정규화(작은 따옴표를 큰 따옴표로 변경), Firebase 설정 파일 생성 단계 추가, Docker 빌드 방식 변경(Buildx에서 ARM64 이미지 빌드로), Gradle 의존성 캐싱 단계 추가 및 구조 정렬이 수행됨.

Changes

Cohort / File(s) Summary
개발 환경 CD 워크플로우
github/workflows/oracle_server_cd_develop.yml
YAML 문자열 정규화(작은 따옴표 → 큰 따옴표), Firebase 설정 생성 단계 추가(base64 디코딩), Buildx 제거 및 ARM64 Docker 이미지 빌드 단계 추가, 형식 및 들여쓰기 조정
릴리스 환경 CD 워크플로우
github/workflows/server_cd_release.yml
YAML 문자열 정규화, Gradle 의존성 캐싱 단계 추가, Firebase 설정 파일 생성 단계 추가(base64 디코딩), Gradle 빌드 단계 추가, 워크플로우 구조 및 공백 조정

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~12 minutes

  • Firebase 설정 단계의 base64 디코딩 로직이 두 워크플로우 간에 동일하게 적용되는지 확인
  • Docker 빌드 방식 변경(Buildx → ARM64)이 배포 환경과 일치하는지 검증 필요
  • 각 워크플로우의 단계 순서와 의존성이 정상 작동하는지 확인

Possibly related PRs

Suggested reviewers

  • Due-IT
  • Zepelown
  • oesnuj
  • seongwon030
✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch cicd/add-firebase-config

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

Disabled knowledge base sources:

  • Jira integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between 0be5bb6 and 60cf3d3.

📒 Files selected for processing (2)
  • .github/workflows/oracle_server_cd_develop.yml (4 hunks)
  • .github/workflows/server_cd_release.yml (5 hunks)

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@lepitaaar lepitaaar deleted the cicd/add-firebase-config branch November 9, 2025 07:23
@coderabbitai coderabbitai bot mentioned this pull request Nov 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

💾 BE Backend 📦 CI/CD CI/CD 관련 설정 및 유지보수

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

Comments