Skip to content

Comments

[CICD] firebase.json 추가#816

Merged
lepitaaar merged 1 commit intodevelop/befrom
cicd/add-firebase-config
Nov 9, 2025
Merged

[CICD] firebase.json 추가#816
lepitaaar merged 1 commit intodevelop/befrom
cicd/add-firebase-config

Conversation

@lepitaaar
Copy link
Contributor

@lepitaaar lepitaaar commented Nov 9, 2025

#️⃣연관된 이슈

ex) #이슈번호, #이슈번호

📝작업 내용

새로추가된 파일 추가했습니다

중점적으로 리뷰받고 싶은 부분(선택)

리뷰어가 특별히 봐주었으면 하는 부분이 있다면 작성해주세요

ex) 메서드 XXX의 이름을 더 잘 짓고 싶은데 혹시 좋은 명칭이 있을까요?

논의하고 싶은 부분(선택)

논의하고 싶은 부분이 있다면 작성해주세요.

🫡 참고사항

Summary by CodeRabbit

릴리스 노트

  • Chores
    • 개발 배포 워크플로우에 수동 트리거 기능 추가
    • 릴리스 배포 워크플로우에 수동 트리거 기능 추가

@lepitaaar lepitaaar self-assigned this Nov 9, 2025
@lepitaaar lepitaaar added 💾 BE Backend 📦 CI/CD CI/CD 관련 설정 및 유지보수 labels Nov 9, 2025
@vercel
Copy link

vercel bot commented Nov 9, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
moadong Ready Ready Preview Comment Nov 9, 2025 7:27am

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Nov 9, 2025

Caution

Review failed

The pull request is closed.

Warning

.coderabbit.yaml has a parsing error

The CodeRabbit configuration file in this repository has a parsing error and default settings were used instead. Please fix the error(s) in the configuration file. You can initialize chat with CodeRabbit to get help with the configuration file.

💥 Parsing errors (1)
Validation error: Invalid regex pattern for base branch. Received: "**" at "reviews.auto_review.base_branches[0]"
⚙️ Configuration instructions
  • Please see the configuration documentation for more information.
  • You can also validate your configuration using the online YAML validator.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Walkthrough

두 개의 GitHub Actions 워크플로우 파일에 workflow_dispatch 트리거를 추가하여 수동 실행 기능을 활성화. 기존 푸시 트리거와 필터는 유지되며, 작업 또는 단계에는 변경 없음.

Changes

Cohort / File(s) 변경 요약
GitHub Actions 워크플로우 트리거 추가
.github/workflows/oracle_server_cd_develop.yml, .github/workflows/server_cd_release.yml
workflow_dispatch 트리거 추가로 수동 워크플로우 실행 지원. 기존 푸시 기반 자동 실행은 유지

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

  • 두 파일 모두 단순하고 동일한 패턴의 트리거 추가 변경
  • 기존 워크플로우 로직 및 단계에 영향 없음

Possibly related PRs

Suggested reviewers

  • Due-IT
  • Zepelown
  • seongwon030
  • PororoAndFriends
✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch cicd/add-firebase-config

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

Disabled knowledge base sources:

  • Jira integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between 24c4822 and 7ff3436.

📒 Files selected for processing (2)
  • .github/workflows/oracle_server_cd_develop.yml (1 hunks)
  • .github/workflows/server_cd_release.yml (1 hunks)

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions
Copy link

github-actions bot commented Nov 9, 2025

Test Results

78 tests   75 ✅  17s ⏱️
13 suites   3 💤
13 files     0 ❌

Results for commit 7ff3436.

@lepitaaar lepitaaar merged commit c974e48 into develop/be Nov 9, 2025
4 of 5 checks passed
@lepitaaar lepitaaar deleted the cicd/add-firebase-config branch November 11, 2025 04:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

💾 BE Backend 📦 CI/CD CI/CD 관련 설정 및 유지보수

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant