Skip to content

[fix] 지원서 이전 모집상태와 비교하지않고 알림을 보내는 문제를 수정한다 #832

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lepitaaar merged 2 commits into from
Nov 10, 2025
Merged

[fix] 지원서 이전 모집상태와 비교하지않고 알림을 보내는 문제를 수정한다 #832

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a27642f
fix: status diff 체크를 안해 무조건 알림 발신이됨
lepitaaar Nov 10, 2025
90a5e33
refactor: 비교 메서드 제거 후 단순 if 문
lepitaaar Nov 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 3 additions & 9 deletions backend/src/main/java/moadong/club/service/RecruitmentStateChecker.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,14 +1,5 @@
package moadong.club.service;

import java.time.ZonedDateTime;
import java.time.format.DateTimeFormatter;
import java.util.List;
import java.util.Locale;

import com.google.firebase.messaging.FirebaseMessaging;
import com.google.firebase.messaging.FirebaseMessagingException;
import com.google.firebase.messaging.Message;
import com.google.firebase.messaging.Notification;
import lombok.RequiredArgsConstructor;
import lombok.extern.slf4j.Slf4j;
import moadong.club.entity.Club;
Expand All @@ -20,6 +11,9 @@
import org.springframework.scheduling.annotation.Scheduled;
import org.springframework.stereotype.Component;

import java.time.ZonedDateTime;
import java.util.List;

@Slf4j
@Component
@RequiredArgsConstructor
Expand Down
4 changes: 4 additions & 0 deletions backend/src/main/java/moadong/club/util/RecruitmentStateCalculator.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,9 +16,13 @@ public class RecruitmentStateCalculator {
public static final int ALWAYS_RECRUIT_YEAR = 2999;

public static void calculate(Club club, ZonedDateTime recruitmentStartDate, ZonedDateTime recruitmentEndDate) {
ClubRecruitmentStatus oldStatus = club.getClubRecruitmentInformation().getClubRecruitmentStatus();
ClubRecruitmentStatus newStatus = calculateRecruitmentStatus(recruitmentStartDate, recruitmentEndDate);
club.updateRecruitmentStatus(newStatus);

if (oldStatus == newStatus)
return;

Message message = buildRecruitmentMessage(club, newStatus);
club.sendPushNotification(message);
}
Expand Down
Loading