Skip to content

Comments

[fix] 프로덕션 호스트 판별 방식 개선#875

Merged
seongwon030 merged 2 commits intomainfrom
hotfix/mixpanel-logging
Nov 20, 2025
Merged

[fix] 프로덕션 호스트 판별 방식 개선#875
seongwon030 merged 2 commits intomainfrom
hotfix/mixpanel-logging

Conversation

@seongwon030
Copy link
Member

@seongwon030 seongwon030 commented Nov 20, 2025

#️⃣연관된 이슈

ex) #이슈번호, #이슈번호

📝작업 내용

  • window.location.href.startsWith(...) 대신 window.location.hostname === 'moadong.com'으로 변경해 프로토콜·경로 차이 때문에 Mixpanel 로그가 차단되는 문제를 해결했습니다.
  • PRODUCTION_HOSTNAMES 배열을 도입해 moadong.com뿐 아니라 www.moadong.com에서도 Mixpanel 로깅이 가능하도록 수정했습니다.

중점적으로 리뷰받고 싶은 부분(선택)

리뷰어가 특별히 봐주었으면 하는 부분이 있다면 작성해주세요

ex) 메서드 XXX의 이름을 더 잘 짓고 싶은데 혹시 좋은 명칭이 있을까요?

논의하고 싶은 부분(선택)

논의하고 싶은 부분이 있다면 작성해주세요.

🫡 참고사항

@seongwon030 seongwon030 self-assigned this Nov 20, 2025
@vercel
Copy link

vercel bot commented Nov 20, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
moadong Ready Ready Preview Comment Nov 20, 2025 9:53am

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Nov 20, 2025

Warning

Rate limit exceeded

@seongwon030 has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 0 minutes and 0 seconds before requesting another review.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

📥 Commits

Reviewing files that changed from the base of the PR and between 20ed9db and 70590af.

📒 Files selected for processing (1)
  • frontend/src/utils/initSDK.ts (1 hunks)

Warning

.coderabbit.yaml has a parsing error

The CodeRabbit configuration file in this repository has a parsing error and default settings were used instead. Please fix the error(s) in the configuration file. You can initialize chat with CodeRabbit to get help with the configuration file.

💥 Parsing errors (1)
Validation error: Invalid regex pattern for base branch. Received: "**" at "reviews.auto_review.base_branches[0]"
⚙️ Configuration instructions
  • Please see the configuration documentation for more information.
  • You can also validate your configuration using the online YAML validator.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json
✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch hotfix/mixpanel-logging

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@seongwon030 seongwon030 added 💻 FE Frontend 🚀 hotfix 즉시 릴리즈할 부분 labels Nov 20, 2025
Copy link
Contributor

@lepitaaar lepitaaar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

production list 추가 좋습니다

Copy link
Member

@oesnuj oesnuj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

일단 확인 해보시져~

@seongwon030 seongwon030 merged commit f7c7411 into main Nov 20, 2025
2 checks passed
@seongwon030 seongwon030 deleted the hotfix/mixpanel-logging branch December 17, 2025 13:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

💻 FE Frontend 🚀 hotfix 즉시 릴리즈할 부분

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants