Skip to content

Comments

[fix] 소개 페이지 동아리 카드의 모집 상태가 불러와지지 않는 오류를 수정한다#899

Merged
suhyun113 merged 1 commit intodevelop-fefrom
fix/club-card-recruit-status
Dec 1, 2025
Merged

[fix] 소개 페이지 동아리 카드의 모집 상태가 불러와지지 않는 오류를 수정한다#899
suhyun113 merged 1 commit intodevelop-fefrom
fix/club-card-recruit-status

Conversation

@suhyun113
Copy link
Collaborator

@suhyun113 suhyun113 commented Nov 26, 2025

#️⃣연관된 이슈

ex) #897

📝작업 내용

소개페이지의 '알수 없음' 상태로 뜨는 모집 상태를 '상시모집'으로 수정

image image

=> 'UPCOMING' 상태가 없는데, 잘못 불러오고 있어서, 변경함

중점적으로 리뷰받고 싶은 부분(선택)

리뷰어가 특별히 봐주었으면 하는 부분이 있다면 작성해주세요

ex) 메서드 XXX의 이름을 더 잘 짓고 싶은데 혹시 좋은 명칭이 있을까요?

논의하고 싶은 부분(선택)

논의하고 싶은 부분이 있다면 작성해주세요.

🫡 참고사항

Summary by CodeRabbit

릴리스 노트

  • 변경사항
    • 클럽 모집 상태 데이터 업데이트: 특정 클럽의 모집 상태가 '예정' 에서 '상시' 로 변경되었습니다.

✏️ Tip: You can customize this high-level summary in your review settings.

@suhyun113 suhyun113 requested a review from oesnuj November 26, 2025 13:47
@suhyun113 suhyun113 self-assigned this Nov 26, 2025
@suhyun113 suhyun113 added 💻 FE Frontend 🛠Fix 기능이 의도한 대로 동작하지 않는 버그를 수정 labels Nov 26, 2025
@vercel
Copy link

vercel bot commented Nov 26, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
moadong Ready Ready Preview Comment Nov 26, 2025 1:47pm

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Nov 26, 2025

Warning

.coderabbit.yaml has a parsing error

The CodeRabbit configuration file in this repository has a parsing error and default settings were used instead. Please fix the error(s) in the configuration file. You can initialize chat with CodeRabbit to get help with the configuration file.

💥 Parsing errors (1)
Validation error: Invalid regex pattern for base branch. Received: "**" at "reviews.auto_review.base_branches[0]"
⚙️ Configuration instructions
  • Please see the configuration documentation for more information.
  • You can also validate your configuration using the online YAML validator.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

개요

모바이 클럽의 채용 상태를 UPCOMING에서 ALWAYS로 업데이트한 단일 파일 데이터 변경입니다.

변경 사항

응집도 / 파일 변경 요약
모의 데이터 업데이트
frontend/src/pages/IntroducePage/constants/mockData.ts
플로팅 클럽 데이터셋의 모바이(moaboza) 클럽의 recruitmentStatus를 UPCOMING에서 ALWAYS로 변경

예상 코드 리뷰 난이도

🎯 1 (매우 간단함) | ⏱️ ~3분

관련 이슈

관련 PR

제안 레이블

🐞 Bug

제안 검토자

  • Zepelown
  • oesnuj
  • seongwon030

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed PR 제목이 주요 변경사항과 일치합니다. 소개 페이지의 동아리 카드 모집 상태 오류 수정이라는 제목이 mockData.ts에서 moaboza 클럽의 recruitmentStatus를 UPCOMING에서 ALWAYS로 변경한 실제 변경사항을 정확히 반영합니다.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch fix/club-card-recruit-status

Tip

📝 Customizable high-level summaries are now available in beta!

You can now customize how CodeRabbit generates the high-level summary in your pull requests — including its content, structure, tone, and formatting.

  • Provide your own instructions using the high_level_summary_instructions setting.
  • Format the summary however you like (bullet lists, tables, multi-section layouts, contributor stats, etc.).
  • Use high_level_summary_in_walkthrough to move the summary from the description to the walkthrough section.

Example instruction:

"Divide the high-level summary into five sections:

  1. 📝 Description — Summarize the main change in 50–60 words, explaining what was done.
  2. 📓 References — List relevant issues, discussions, documentation, or related PRs.
  3. 📦 Dependencies & Requirements — Mention any new/updated dependencies, environment variable changes, or configuration updates.
  4. 📊 Contributor Summary — Include a Markdown table showing contributions:
    | Contributor | Lines Added | Lines Removed | Files Changed |
  5. ✔️ Additional Notes — Add any extra reviewer context.
    Keep each section concise (under 200 words) and use bullet or numbered lists for clarity."

Note: This feature is currently in beta for Pro-tier users, and pricing will be announced later.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (1)
frontend/src/pages/IntroducePage/constants/mockData.ts (1)

20-20: 상태 값 변경은 PR 목적에 부합합니다만, 상태 문자열은 상수/타입으로 묶는 것을 고려해보세요.

recruitmentStatus: 'ALWAYS'로 바꾼 것은 소개 카드에서 "상시모집"이 제대로 노출되도록 하는 목적에 잘 맞고, 주변의 'OPEN', 'CLOSED'와도 일관적입니다.

다만 이번 이슈처럼 존재하지 않는 상태 문자열을 쓰면 런타임에서만 드러나는 버그가 다시 생길 수 있으니,
Club['recruitmentStatus']를 문자열 리터럴 유니온/enum이나 공통 상수(예: RECRUIT_STATUS.ALWAYS)로 강하게 제한하고, 목업 데이터도 그 상수를 사용하도록 정리해 두면 안전성이 더 높아질 것 같습니다. (코딩 가이드라인의 "상수 정의로 묵시적 실패 방지" 항목과도 맞습니다.)

📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

Disabled knowledge base sources:

  • Jira integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between 7f8a549 and f15671d.

📒 Files selected for processing (1)
  • frontend/src/pages/IntroducePage/constants/mockData.ts (1 hunks)
🧰 Additional context used
📓 Path-based instructions (2)
frontend/**/*.{ts,tsx,js,jsx}

📄 CodeRabbit inference engine (frontend/.cursorrules)

frontend/**/*.{ts,tsx,js,jsx}: Replace magic numbers with named constants for clarity
Replace complex/nested ternaries with if/else or IIFEs for readability
Assign complex boolean conditions to named variables for explicit meaning
Avoid hidden side effects; functions should only perform actions implied by their signature (Single Responsibility Principle)
Use unique and descriptive names for custom wrappers/functions to avoid ambiguity
Define constants near related logic or ensure names link them clearly to avoid silent failures
Break down broad state management into smaller, focused hooks/contexts to reduce coupling

Files:

  • frontend/src/pages/IntroducePage/constants/mockData.ts
frontend/**/*.{ts,tsx}

📄 CodeRabbit inference engine (frontend/.cursorrules)

Use consistent return types for similar functions/hooks

Files:

  • frontend/src/pages/IntroducePage/constants/mockData.ts
🧠 Learnings (1)
📓 Common learnings
Learnt from: seongwon030
Repo: Moadong/moadong PR: 195
File: frontend/src/pages/AdminPage/AdminPage.tsx:7-7
Timestamp: 2025-03-19T05:18:07.818Z
Learning: AdminPage.tsx에서 현재 하드코딩된 클럽 ID('67d2e3b9b15c136c6acbf20b')는 로그인 기능 구현 후 동적으로 가져오는 방식으로 수정될 예정입니다.

Copy link
Member

@oesnuj oesnuj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

빠른 버그 수정 좋습니다~

@suhyun113 suhyun113 merged commit c979e44 into develop-fe Dec 1, 2025
3 checks passed
@suhyun113 suhyun113 deleted the fix/club-card-recruit-status branch December 1, 2025 01:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

💻 FE Frontend 🛠Fix 기능이 의도한 대로 동작하지 않는 버그를 수정

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants