Skip to content

Comments

Revert "[hotfix] SNS 링크 버튼 클릭이벤트를 수집한다"#996

Merged
seongwon030 merged 1 commit intomainfrom
revert-995-feature/#994-sns-link-btn-data-log-MOA-473
Dec 30, 2025
Merged

Revert "[hotfix] SNS 링크 버튼 클릭이벤트를 수집한다"#996
seongwon030 merged 1 commit intomainfrom
revert-995-feature/#994-sns-link-btn-data-log-MOA-473

Conversation

@seongwon030
Copy link
Member

@seongwon030 seongwon030 commented Dec 30, 2025

Reverts #995

Summary by CodeRabbit

릴리스 노트

  • 리팩토링
    • 클럽 프로필 카드 컴포넌트의 코드 구조를 개선했습니다.
    • 추적 기능을 제거하고 코드 가독성을 향상시켰습니다.

✏️ Tip: You can customize this high-level summary in your review settings.

@vercel
Copy link

vercel bot commented Dec 30, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Review Updated (UTC)
moadong Ready Ready Preview, Comment Dec 30, 2025 5:42am

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Dec 30, 2025

Warning

.coderabbit.yaml has a parsing error

The CodeRabbit configuration file in this repository has a parsing error and default settings were used instead. Please fix the error(s) in the configuration file. You can initialize chat with CodeRabbit to get help with the configuration file.

💥 Parsing errors (1)
Validation error: Invalid regex pattern for base branch. Received: "**" at "reviews.auto_review.base_branches[0]"
⚙️ Configuration instructions
  • Please see the configuration documentation for more information.
  • You can also validate your configuration using the online YAML validator.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Walkthrough

ClubProfileCard 컴포넌트에서 Mixpanel 분석 추적 관련 import와 SNS 링크 클릭 이벤트 핸들러를 제거합니다. 코드 가독성 향상을 위해 구조적 UI 주석을 추가하고 포맷팅을 조정했습니다.

Changes

Cohort / File(s) 변경 사항
Mixpanel 추적 제거
frontend/src/pages/ClubDetailPage/components/ClubProfileCard/ClubProfileCard.tsx
USER_EVENT, useMixpanelTrack import 제거; SNS 링크 클릭 시 mixpanel 이벤트 발생 핸들러 삭제; 커버 이미지, 로고, 클럽 정보, 소개 섹션에 구조적 주석 추가; IntroDescription 내용 줄바꿈 조정

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3분

Possibly related PRs

Suggested labels

💻 FE, 🛠Fix

Suggested reviewers

  • oesnuj

Pre-merge checks and finishing touches

❌ Failed checks (1 inconclusive)
Check name Status Explanation Resolution
Linked Issues check ❓ Inconclusive 이 PR은 MOA-473의 SNS 링크 추적 기능 구현을 되돌리는 작업입니다. 그러나 MOA-473의 원래 목표는 SNS 링크 클릭 이벤트 수집이었으므로 상충됩니다. PR이 되돌리기이므로 원래 MOA-473 요구사항을 되돌리는 것이 의도인지, 아니면 다른 이슈를 참조해야 하는지 명확히 해야 합니다.
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed PR 제목이 변경사항의 주요 내용을 명확하게 요약합니다. Mixpanel 추적 관련 코드를 제거하는 되돌리기 작업을 정확히 설명합니다.
Out of Scope Changes check ✅ Passed 모든 변경사항(Mixpanel 임포트 제거, onClick 핸들러 제거, UI 주석 추가)이 SNS 링크 클릭 추적 기능 되돌리기와 관련이 있습니다.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✨ Finishing touches
  • 📝 Generate docstrings

📜 Recent review details

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Disabled knowledge base sources:

  • Jira integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between 274c512 and da7c82e.

📒 Files selected for processing (1)
  • frontend/src/pages/ClubDetailPage/components/ClubProfileCard/ClubProfileCard.tsx
🧰 Additional context used
📓 Path-based instructions (3)
frontend/**/*.{ts,tsx,js,jsx}

📄 CodeRabbit inference engine (frontend/.cursorrules)

frontend/**/*.{ts,tsx,js,jsx}: Replace magic numbers with named constants for clarity
Replace complex/nested ternaries with if/else or IIFEs for readability
Assign complex boolean conditions to named variables for explicit meaning
Avoid hidden side effects; functions should only perform actions implied by their signature (Single Responsibility Principle)
Use unique and descriptive names for custom wrappers/functions to avoid ambiguity
Define constants near related logic or ensure names link them clearly to avoid silent failures
Break down broad state management into smaller, focused hooks/contexts to reduce coupling

Files:

  • frontend/src/pages/ClubDetailPage/components/ClubProfileCard/ClubProfileCard.tsx
frontend/**/*.{tsx,jsx}

📄 CodeRabbit inference engine (frontend/.cursorrules)

frontend/**/*.{tsx,jsx}: Abstract complex logic/interactions into dedicated components/HOCs
Separate significantly different conditional UI/logic into distinct components
Colocate simple, localized logic or use inline definitions to reduce context switching
Choose field-level or form-level cohesion based on form requirements when using form libraries like react-hook-form
Use Component Composition instead of Props Drilling to reduce coupling

Files:

  • frontend/src/pages/ClubDetailPage/components/ClubProfileCard/ClubProfileCard.tsx
frontend/**/*.{ts,tsx}

📄 CodeRabbit inference engine (frontend/.cursorrules)

Use consistent return types for similar functions/hooks

Files:

  • frontend/src/pages/ClubDetailPage/components/ClubProfileCard/ClubProfileCard.tsx
🧠 Learnings (2)
📓 Common learnings
Learnt from: seongwon030
Repo: Moadong/moadong PR: 195
File: frontend/src/pages/AdminPage/AdminPage.tsx:7-7
Timestamp: 2025-03-19T05:18:07.818Z
Learning: AdminPage.tsx에서 현재 하드코딩된 클럽 ID('67d2e3b9b15c136c6acbf20b')는 로그인 기능 구현 후 동적으로 가져오는 방식으로 수정될 예정입니다.
📚 Learning: 2025-03-19T05:18:07.818Z
Learnt from: seongwon030
Repo: Moadong/moadong PR: 195
File: frontend/src/pages/AdminPage/AdminPage.tsx:7-7
Timestamp: 2025-03-19T05:18:07.818Z
Learning: AdminPage.tsx에서 현재 하드코딩된 클럽 ID('67d2e3b9b15c136c6acbf20b')는 로그인 기능 구현 후 동적으로 가져오는 방식으로 수정될 예정입니다.

Applied to files:

  • frontend/src/pages/ClubDetailPage/components/ClubProfileCard/ClubProfileCard.tsx
🔇 Additional comments (2)
frontend/src/pages/ClubDetailPage/components/ClubProfileCard/ClubProfileCard.tsx (2)

59-59: 구조적 주석 추가로 가독성 향상

컴포넌트의 주요 섹션(커버 이미지, 로고, 클럽 정보, 소개 섹션)을 명확히 구분하는 주석이 추가되어 코드 가독성이 개선되었습니다.

Also applies to: 67-67, 72-72, 74-74, 109-109


1-121: Revert 의도 확인 필요

이 PR은 SNS 링크 클릭 이벤트 추적 기능을 제거하는 revert입니다. 그러나 연결된 이슈 MOA-473의 목표는 "SNS링크 버튼 클릭이벤트를 수집한다"로, 추적 기능을 추가하는 것이었습니다.

Revert가 의도적인지, 그리고 추적 기능을 다른 방식으로 다시 구현할 계획이 있는지 확인이 필요합니다.

다음 사항을 확인해 주세요:

  1. 이 revert가 의도적인 것인지
  2. Revert 사유 (구현 이슈, 성능 문제, 개인정보 보호 우려 등)
  3. 추적 기능을 다른 방식으로 재구현할 계획이 있는지

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@seongwon030 seongwon030 merged commit fa4d869 into main Dec 30, 2025
3 checks passed
@seongwon030 seongwon030 deleted the revert-995-feature/#994-sns-link-btn-data-log-MOA-473 branch December 30, 2025 05:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants