Feature/netstandard #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… This is a *BREAKING* CHANGE.
…6a68)" into history using rebase
|
Since I "added" my commit to the history using rebase, there is shown to be a lot of changes, but it should (I hope) match your branch. If you can make it work with this, I should have my "commit"-contribution. If it doesn't work, or is too much of a pain to get to work, you can just close this and I'll survive without having the contribution :) |
MoaidHathot
approved these changes
Jul 10, 2023
There was a problem hiding this comment.
I meant that you could copy my branch into yours then create a PR for merging your branch into the Main branch, so that your contribution is fully reflected in the file history :)
But this PR is fine as well, the Solution Items are a good contribution too, thanks for that!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds commit into commit history to get "commit-contribution-points" as discussed in #2.
Also adds solution items such as readme, build.props and editor config into branch