Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove incorrect helper text from output configs #1799

Merged
merged 1 commit into from
Jul 23, 2024

Conversation

neilenns
Copy link
Contributor

Fixes #1798

Add a test for whether the dialog is input vs. output to the existing test for when to show the helper text. After the change, output looks like this:

image

Input looks like this:

image

@neilenns neilenns requested a review from DocMoebiuz as a code owner July 14, 2024 17:41
Copy link

Build for this pull request:
MobiFlightConnector.zip

Copy link
Collaborator

@DocMoebiuz DocMoebiuz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes!

@DocMoebiuz DocMoebiuz merged commit 7230d19 into MobiFlight:main Jul 23, 2024
1 check passed
@DocMoebiuz DocMoebiuz added enhancement Improvement of an existing feature bug Something isn't working in a officially released version and removed enhancement Improvement of an existing feature labels Aug 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working in a officially released version
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Output config code box does not support placeholders
2 participants