Don't try and install the WASM module for MSFS versions that aren't installed #1868
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Build for this pull request: |
|
Build for this pull request: |
|
Build for this pull request: |
neilenns
commented
Nov 28, 2024
| @@ -140,7 +140,6 @@ public bool InstallWasmModule(string communityFolder) | |||
| // Remove the old Wasm File | |||
| DeleteOldWasmFile(communityFolder); | |||
|
|
|||
| Log.Instance.log("WASM module has been installed successfully.", LogSeverity.Info); | |||
There was a problem hiding this comment.
The caller now logs this based on the return value so different log messages can be sent based on the simulator version.
|
Build for this pull request: |
DocMoebiuz
reviewed
Dec 1, 2024
|
Build for this pull request: |
|
@DocMoebiuz I unwound the if statements, thanks for the suggestion. So much better. |
|
Build for this pull request: |
DocMoebiuz
approved these changes
Dec 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1867