Add SwiftCompile as detailType
#182
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PatrikBillgren
requested review from
polac24,
ecamacho,
aleksandergrzyb and
CognitiveDisson
as code owners
It seems that in Xcode 14 the signature prefix for swiftCompilation is now `SwiftCompile ...`. I added it in the parsing logic to keep supporting the old Xcode versions as well Signed-off-by: Patrik Billgren <pbillgren@spotify.com>
PatrikBillgren
force-pushed
the
fix-swift-file-compile-parsing
branch
from
f371f0c to
183d163
Compare
aleksandergrzyb
approved these changes
Nov 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems that in Xcode 14 the signature prefix for swiftCompilation is now
SwiftCompile .... I added it in the parsing logic to keep supporting the old Xcode versions as wellTest this by parsing a project with Swift files and look for the presence of Swift files in the HTML format output
