-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat/typescript v31 rc #130
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks @Alessandro100!
I added a few suggestions.
It would be good that a dev from MobilityData reviews this PR 🙏
testFixtures/v3.1-RC/manifest.json
Outdated
"url": "https://platform-services.tier-services.io/data-sharing/tier_tier_fingal/gbfs/3.1-RC", | ||
"version": "3.1-RC" | ||
} | ||
] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggestion to add area
and country_code
in the manifest.json test to cover MobilityData/gbfs#572.
Example was found in https://github.com/MobilityData/gbfs/blob/master/gbfs.md#manifestjson.
] | |
], | |
"area": { | |
"type": "MultiPolygon", | |
"coordinates": [ | |
[ | |
[ | |
[ | |
13.10821, | |
52.58563 | |
], | |
[ | |
13.29743, | |
52.67046 | |
], | |
[ | |
13.48451, | |
52.6855 | |
], | |
[ | |
13.77993, | |
52.43458 | |
], | |
[ | |
13.65355, | |
52.33048 | |
], | |
[ | |
13.08165, | |
52.38793 | |
], | |
[ | |
13.10821, | |
52.58563 | |
] | |
] | |
] | |
] | |
}, | |
"country_code": "DE" |
testFixtures/v3.1-RC/manifest.json
Outdated
"system_id": "tier_fingal", | ||
"versions": [ | ||
{ | ||
"url": "https://platform-services.tier-services.io/data-sharing/tier_tier_fingal/gbfs/2.1", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it would be more neutral to use random names and URLs for the test files instead of those from a real operator. Thoughts @emmambd?
Example was found in https://github.com/MobilityData/gbfs/blob/master/gbfs.md#manifestjson.
"system_id": "tier_fingal", | |
"versions": [ | |
{ | |
"url": "https://platform-services.tier-services.io/data-sharing/tier_tier_fingal/gbfs/2.1", | |
"system_id": "example_berlin", | |
"versions": [ | |
{ | |
"url": "https://berlin.example.com/gbfs/2/gbfs", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@richfab Makes sense to me!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Alessandro100 Can you please update the test files with examples from https://github.com/MobilityData/gbfs/blob/master/gbfs.md#manifestjson?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
great idea
#122
This PR adds support for gbfs v3.1-rc to typescript language bindings
Changes:
- files are generated on postinstall
yarn install