Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Timezone not properly validated #76

Closed
mikael-epigram opened this issue Jul 15, 2022 · 3 comments · Fixed by #82
Closed

Timezone not properly validated #76

mikael-epigram opened this issue Jul 15, 2022 · 3 comments · Fixed by #82
Assignees

Comments

@mikael-epigram
Copy link

Timezone as defined in https://github.com/NABSA/gbfs/blob/v2.3/gbfs.md#field-types
states:

Timezone - TZ timezone from the https://www.iana.org/time-zones. Timezone names never contain the space character but MAY contain an underscore. Refer to https://en.wikipedia.org/wiki/List_of_tz_zones for a list of valid values. Example: Asia/Tokyo, America/Los_Angeles or Africa/Cairo.

The schema in system_information.json seems to not make any requirements of the field:

"timezone": {
    "description": "The time zone where the system is located.",
    "type": "string"
},

This does not seem to comply to the gbfs standard

@leonardehrenfried
Copy link

Examples of invalid time zones:

So it's more common than I hoped.

@isabelle-dr
Copy link
Contributor

@PierrickP this has been updated on the Json Schema 😊

@PierrickP
Copy link
Collaborator

#82 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants