Remove parsing of GBFS timezones #4313
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leonardehrenfried
added
IBI
hannesj
previously approved these changes
Jul 27, 2022
hannesj
reviewed
Jul 27, 2022
| @@ -18,7 +16,6 @@ public class VehicleRentalSystem { | |||
| public final String phoneNumber; | |||
| public final String email; | |||
| public final String feedContactEmail; | |||
| public final ZoneId timezone; | |||
There was a problem hiding this comment.
Would it be ok to just store it as String here?
There was a problem hiding this comment.
Sure, why not.
Codecov Report
@@ Coverage Diff @@
## dev-2.x #4313 +/- ##
=============================================
+ Coverage 57.13% 57.18% +0.05%
- Complexity 10779 10786 +7
=============================================
Files 1429 1428 -1
Lines 58086 58020 -66
Branches 6728 6728
=============================================
- Hits 33185 33181 -4
+ Misses 22891 22830 -61
+ Partials 2010 2009 -1
Continue to review full report at Codecov.
|
hannesj
approved these changes
Jul 27, 2022
optionsome
approved these changes
Jul 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Sadly there are many invalid GBFS feeds out there which send an incorrect timezone.
Examples:
Unfortunately, the validator doesn't validate this yet: MobilityData/gbfs-validator#76
This causes OTP to completely reject the feed.
Since we actually don't really need the timezone I've skipped parsing it and using an
Instantinstead.