Add validatorVersion on API responses
#78
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for gbfs-validator ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
PierrickP
force-pushed
the
add-validator-version
branch
2 times, most recently
from
d4bf771 to
e541382
Compare
Return git hash on netlify, based on COMMIT_REF env variable or package.json's version Close #77
PierrickP
force-pushed
the
add-validator-version
branch
from
e541382 to
31c5325
Compare
|
@AntoineAugusti is it ok for you ? You can test the PR version on https://deploy-preview-78--gbfs-validator.netlify.app/ |
|
Works well, thanks for working on this! 🙏 |
|
Thank you @PierrickP! |
❌ Deploy Preview for competent-payne-690ca9 failed.
|
✅ Deploy Preview for unruffled-hugle-914373 ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
❌ Deploy Preview for kind-pike-a3f3f8 failed.
|
❌ Deploy Preview for wizardly-engelbart-5c48ca failed.
|
❌ Deploy Preview for wizardly-lichterman-770f54 failed.
|
isabelle-dr
approved these changes
Aug 22, 2022
There was a problem hiding this comment.
Looks good to me, thank you @PierrickP for working on this! Merging this PR
|
Wonderful, cheers! 🙇 |
josee-sabourin
pushed a commit
that referenced
this pull request
Apr 25, 2023
…170e f43170e V3.0-RC Schemas (#79) 680df70 Update pr-to-project.yml c2c30a2 Typo fix in geofencing_zones.json (#78) c9be765 Create pr-to-project.yml 0a17875 Create issues-to-project.yml 30e5a3a Update README.md git-subtree-dir: gbfs-validator/versions/schemas git-subtree-split: f43170e95d0969922a200a512cc5ab494702f79c
tdelmas
added a commit
to tdelmas/gbfs-validator
that referenced
this pull request
Jun 28, 2023
…058d 22b058d fix: incorrect spec for "languages" property in system_information.json (MobilityData#90) e9d891b Refer to later versions in gbfs_versions.json (MobilityData#87) fbd3ced Add v3.0 to v3.0-RC schemas (MobilityData#88) ef0d9a6 Fix schemas for v3.0-RC (MobilityData#85) 2b6ad1e FIX: replaces name field with localized string (MobilityData#82) abe71f2 Fix invalid json, no trailing commas (MobilityData#83) f43170e V3.0-RC Schemas (MobilityData#79) 680df70 Update pr-to-project.yml c2c30a2 Typo fix in geofencing_zones.json (MobilityData#78) c9be765 Create pr-to-project.yml 0a17875 Create issues-to-project.yml 30e5a3a Update README.md git-subtree-dir: gbfs-validator/versions/schemas git-subtree-split: 22b058dc4a358baf451e006cde74775075929b3d
richfab
pushed a commit
that referenced
this pull request
Jun 29, 2023
* Git ignore for schemas subtree Signed-off-by: Tom <1955774+tdelmas@users.noreply.github.com> * Squashed 'gbfs-validator/versions/schemas/' changes from 5273f96..22b058d 22b058d fix: incorrect spec for "languages" property in system_information.json (#90) e9d891b Refer to later versions in gbfs_versions.json (#87) fbd3ced Add v3.0 to v3.0-RC schemas (#88) ef0d9a6 Fix schemas for v3.0-RC (#85) 2b6ad1e FIX: replaces name field with localized string (#82) abe71f2 Fix invalid json, no trailing commas (#83) f43170e V3.0-RC Schemas (#79) 680df70 Update pr-to-project.yml c2c30a2 Typo fix in geofencing_zones.json (#78) c9be765 Create pr-to-project.yml 0a17875 Create issues-to-project.yml 30e5a3a Update README.md git-subtree-dir: gbfs-validator/versions/schemas git-subtree-split: 22b058dc4a358baf451e006cde74775075929b3d * remove dot files in schemas Signed-off-by: Tom <1955774+tdelmas@users.noreply.github.com> * v3-RC validation Signed-off-by: Tom <1955774+tdelmas@users.noreply.github.com> * Remove unused file Signed-off-by: Tom <1955774+tdelmas@users.noreply.github.com> * Add `serverOpts` required in Windows Signed-off-by: Tom <1955774+tdelmas@users.noreply.github.com> * Fix typo `recommended` Signed-off-by: Tom <1955774+tdelmas@users.noreply.github.com> * update test for 3.0-RC , 3.0 and upcoming minor versions Signed-off-by: Tom <1955774+tdelmas@users.noreply.github.com> * fix after rebase Signed-off-by: Tom <1955774+tdelmas@users.noreply.github.com> * Recommended. Signed-off-by: Tom <1955774+tdelmas@users.noreply.github.com> * Squashed 'gbfs-validator/versions/schemas/' changes from 22b058d..5f12243 5f12243 Patch manifest.json (#91) git-subtree-dir: gbfs-validator/versions/schemas git-subtree-split: 5f12243d5735a608eef697212a627b9090eea31a --------- Signed-off-by: Tom <1955774+tdelmas@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Return git hash on netlify, based on COMMIT_REF env variable or package.json's version
Close #77