-
Notifications
You must be signed in to change notification settings - Fork 293
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Are feed URLs required to end with ".json"? #139
Comments
For the PBSC cities above (Toronto, Nicosia, Lousville, Tucson), we support both access methods, with and without .json. The root auto-discover endpoint also supports gbfs.json in the latest version. For example Barcelona: https://barcelona.publicbikesystem.net/ube/gbfs/v1/gbfs.json. As the other cities are updated to the newer version, I will update the system.csv file to reflect the changes. |
@barbeau Regarding both of your questions, it was never the intent to dictate the actual filenames, as I consider those to be an implementation detail of the provider. For example, I could see a provider potentially building the JSON files statically and letting something like S3 or a regular web server serve them up - in that case the server might require a The feeds do have to be valid JSON though, so I would expect the servers to serve them with the correct content type: |
Thanks @jcn, I was wondering if the filenames themselves were indeed flexible. To make things a little clearer for consumers, I'd suggest the following:
|
I propose we be even more explicit and just make the auto-discovery file required. Every provider in the We would still need to make the keys explicit, which would be, I'd imagine, the base file name of each feed. |
@jcn Requiring auto-discovery file and using base file name as explicit key sounds good to me. |
@antrim I think the proposal itself can be advanced as-is. However, to be most useful I think it requires versioning in the spec. Without an explicit version in the auto-discovery URL response, apps won't know if a particular feed has the standardized keys to be able to find the rest of the endpoints. |
@antrim @barbeau Agree that this should be advanced as is. Regarding versions, perhaps we can move the discussion to #163 (which seems like a good a place as any to discuss this) but I propose we should take this and all other "clarifying" spec changes and release a 1.1.0 as a base starting point for future enhancements. |
We at IBI also just noticed this oddity about the HOPR feed. We support advancing this proposal to get clarification. |
@heidiguenin Yes, I'll work on a proposal for this. |
I've opened a proposal at #189 for review. Comments welcome! |
Closing this issue now that PR is open. |
Awaiting implementation by a producer or consumer. Adding to v2.0 Release Candidate. * Fix #139 - Require autodiscovery gbfs.json file, define feed names
Reading the spec, I would assume that the URL endpoints that are defined in the spec (for example,
station_information.json
) would always include the.json
extension.However, I see a number of feeds in the wild, including many in the
systems.csv
file in this repo, that don't include the .json
extension on the end of the URL - for example:https://gbfs.hopr.city/api/gbfs/8/free_bike_status
...instead of:
https://gbfs.hopr.city/api/gbfs/8/free_bike_status.json
The
gbfs.json
auto-discovery endpoint example listed here in the reference also doesn't include the.json
file extensions on any of the listed URLs.Additionally, many of these feeds have the auto-discovery feed as a root directory instead of with a
gbfs.json
endpoint - for example:https://tor.publicbikesystem.net/ube/gbfs/v1/
...instead of:
https://tor.publicbikesystem.net/ube/gbfs/v1/gbfs.json
Example feeds with these properties:
Questions:
.json
to officially conform with the spec?gbfs.json
and still conform with the spec?The text was updated successfully, but these errors were encountered: