-
Notifications
You must be signed in to change notification settings - Fork 290
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Require license_url, add attribution fields #182
Conversation
Make license_url "Required", add attribution fields and add inventory of common data licenses.
Can we use SPDX license IDs? This is what most OSS tools have converged around, and I think it makes sense here as well. |
@contra : Makes good sense. I'll revise the PR. |
SPDX License List
Creative Commons Universal Public Domain Dedication (added text for 'license_url')
I've revised the PR:
Since the introduced requirement makes the change backwards-compatibility breaking, then this would need to be part of a MAJOR version. (see #188) What this PR does NOT currently do:
|
update column name and link
clarify identifiers and names
expand the full names of licenses
I hereby call a vote on this proposal. Because of the US Thanksgiving holiday, I propose we extend by 1 day. Voting will be open for 8 full days, until 11:59PM UTC on Tuesday, Dec 3. Please vote for or against the proposal to add a data license, and include the organization for which you are voting in your comment. |
@antrim I know in some states (including Florida) Thursday and Friday are both considered holidays: ...so I'd suggest giving two additional days to account for this. |
Following @barbeau 's suggestion, I'd like to extend the voting period until 11:59PM UTC on Dec 6 to accommodate the USA Thanksgiving holiday. Please vote, and note if you can commit to implementing this proposal. |
+1 from Stae |
+1 from PBSC |
+1 Ride Report |
+1 from IBI Group |
Note: I think we should change the markdown style so that there are not extra spaces in the tables. When we change the column widths it makes it harder to do line-by-line comparisons in GitHub.
makes it easier to read
Voting has closed and this changed has been passed. Four votes were in favor:
@MobilityData is refining how we'll implement the versioning scheme (#188). We'll merge this once we arrive at a sensible release process (see #163). |
Merged - branch deleted. |
We'd love to make this an official part of the spec, but first we need to see this change being implemented. Could you comment here if your organization has implemented this? [Sorry to those of you fabulously active community members who will see this message over and over again today!] @evansiroky @quicklywilliam @madupras @contra Others? |
We still have multiple months before tackling this change at PBSC. It's in our "GBFS version 2" internal project which is planned for the Q3/Q4 2020. |
license_url
is an optional field insystem_information.json
(added in PR #49). This new pull request would make a backwards-compatibility breaking change to definelicense_url
as mandatory. The outcome of the discussion related to versioning (issue #15) would define how such a change would be treated and incorporated into the spec.This proposal would:
feed_license
a mandatory field.license_url
being present but empty means the feed is released without a license (public domain).