Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New GBFS enabled provider added #203

Closed

Conversation

artem-vereshchaka
Copy link

Added new record to systems.csv with GBFS enabled provider

Copy link
Contributor

@jcn jcn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This does not seem to be a valid feed - the free_bike_status endpoint is returning a 500. I'm not sure if it's temporarily broken or not live, but it shouldn't be merged in until it's fixed.

@artem-vereshchaka
Copy link
Author

@jcn , the given city is closed right now (due to weather conditions). Spec says that it should work in this way if there are no available vehicles.
We are about to open more cities soon that will operate in winter also.

I will also update PR in order to add another operational city.

@heidiguenin
Copy link
Contributor

@jcn - what are your thoughts on this given the discussion in #202 ?

@jcn
Copy link
Contributor

jcn commented Feb 17, 2020

Spec says that it should work in this way if there are no available vehicles.

@artem-vereshchaka The original problem I raised was that the endpoint was returning a 500 error HTTP response code and both proposed new feeds are now returning a 400. The spec does not indicate that this is a valid response, and as per the discussion in #202 that @heidiguenin references, the bixi systems that are closed seasonally return valid feeds when they are closed, just with no available vehicles.

These feeds should be updated in the same way in order to be included in the systems.csv file.

@stale
Copy link

stale bot commented Nov 13, 2020

This disucssion has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Nov 13, 2020
@artem-vereshchaka
Copy link
Author

I don't think we should proceed with this PR anymore and merge it.
Cities do not use this repo as a source, so I assume we are not required to be mentioned here as well.

If anything -- just ping me directly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants