Transition from "bike" to "vehicle" to support new vehicle types #236
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I've opened the PR for your request, @charlesjump. I think this should cover everything - let me know! |
bddq
reviewed
Jun 2, 2020
|
If this change were voted on and passed by the community, it would be merged into a future major release. |
|
This disucssion has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
josee-sabourin
added
stale
v3.0-RC
|
With all of the updates to the specification since this was opened, I'm closing it & will re-do when we're closer to a v3.0 change process! |
mplsmitch
removed
proposal:breaking
v3.0-RC
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes references to "bike" or "bikes" (short of the name "GBFS" itself) to the more generic "vehicle" or "vehicles" throughout.
During the vehicle types definitions discussion, switching the references from "bikes" to the more generic "vehicles" came up repeatedly, but in order to keep those updates backwards compatible, we're tackling this piece separately.