Fix JSON examples #374
Merged
Fix JSON examples #374
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks @ellen364 ! |
fchabouis
pushed a commit
to etalab/gbfs-carsharing-extension
that referenced
this pull request
Nov 4, 2021
mplsmitch
pushed a commit
that referenced
this pull request
Dec 27, 2021
* add carsharing infos to vehicle_types.json * update station_information.json for carsharing support * update free_bike_status for carsharing extension Add "Datetime" in Fields In free_bike_status.json Add : - "current_range_percent" - "available_until" - "home_station" Change the description of "current_range_meters" * Update vehicle_type.json for carsharing support Add : vehicle_description - Make - Model - Color * remove microseconds * vehicule descitption is not an object, but additional fields * remove xtra white spaces * update free_bike_status.json add forgotten field : vehicule equipement * Add vXXX in all new files * Corrections * remove extra coma * rename current_range_percent to current_fuel_percent * add mention of the WLTP standard * add "fuel-cell powered motor" to propulsion type / electric field desc * Revert "Merge remote-tracking branch 'nabsa/master'" This reverts commit a5f74b9, reversing changes made to 414fdd3. * cherry-pick after merge revert Editorial and JSON example changes (#380) * cherry-pick after merge revert Rename v3.0 from RC to Draft Changes reference to v3.0-RC to v3.0-Draft to indicate future version, not ready for release candidate. * fix merge issue : add "fuel-cell powered motor" to propulsion type / electric field desc * fix json examples * change vehicle_type_accessories to vehicle_accessories and example correction * fix merge issue, cherry-pick : Fix JSON examples (#374) * remove constraint on make and model case * update example * add options doors_2, doors_3, doors_5 * Change min_cargo_volume_ capacity and min_cargo_load_capacity Change - min_cargo_volume_ capacity to cargo_volume_ capacity - min_cargo_load_capacity to cargo_load_capacity * correct typo cargo_volume_capacity * propulsion_type becomes plug_in_hybrid * Make "current_fuel_percent" optional * Remove condition on "current_range_meters" * spell vehicle correctly * current_fuel_percent is optional * remove extra space Co-authored-by: Daniel <36266644+nbdh@users.noreply.github.com> * corrections on json examples formatting * remove JPG from allowed formats list * removal of details on the number of pixels "vehicle_image" * Modification of child_seat values * Modification propulsion type modification of : the definition of electric propulsion the name of the hydrogen propulsion Co-authored-by: Miryad <Miryad3108@users.noreply.github.com> Co-authored-by: Mitch Vars <mitch@mobilitydata.org> Co-authored-by: Ellen <38250543+ellen364@users.noreply.github.com> Co-authored-by: Miryad <59559301+Miryad3108@users.noreply.github.com> Co-authored-by: Thibaut Barrère <thibaut.barrere@gmail.com> Co-authored-by: Daniel <36266644+nbdh@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: If your PR is to add, remove, or correct a system in systems.csv, please delete this template.
If you are new to the specification, please introduce yourself (name and organization/link to GBFS). It’s helpful to know who we're chatting with!
Hi, I'm Ellen. I work at Ito World.
What problem does your proposal solve? Please begin with the relevant issue number. If there is no existing issue, please also describe alternative solutions you have considered.
Fixes a few things in the JSON examples in gbfs.md, mostly making types consistent with the spec.
Changes:
Is this a breaking change?
Which files are affected by this change?
gbfs.md